Skip to content

Added getUserMedia option style detection #1

Merged
merged 1 commit into from Mar 13, 2012

2 participants

@phuu
phuu commented Mar 13, 2012

Based on work by @miketaylr here, and me here.

Should allow this shim to support browsers with string style or object style options.

@phuu phuu Added getUserMedia option style detection to support implementations …
…that use string and dictionary style implementations.
d9ae0bf
@addyosmani
Owner

Great work, @phuu!. I'll be doing some testing on this this afternoon just to confirm the demos still play nice, but otherwise the PR is looking solid. Should be able to merge today. Thanks!.

@phuu
phuu commented Mar 13, 2012

Cheers.

I should say, I've tested in the Opera Labs Camera build, Opera Next 12.0.0, Opera 11.61, Chrome 17.0.963.79, Chrome Canary 19.0.1067.0 and Firefox 10.0.2 all on OSX Lion. I woulda done IE, but I don't have my external drive with the VMs on it!

@addyosmani
Owner

Very useful to know! Cheers. I'll get the IE testing out of the way and cover testing on Windows + Leopard for the others.

@addyosmani addyosmani merged commit 152f0c3 into addyosmani:master Mar 13, 2012
@addyosmani
Owner

Thanks for this again @phuu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.