Use default max packet size for SFTP #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes
nmon2influxdb
so it uses the default MaxPacket size from frompkg/sftp
.A change to
pkg/sftp
(this commit) made in January brokenmon2influxdb
's capacity to fetch remote files.The reason is that the MaxPacket size used by
nmon2influxdb
, 64000 bytes, is too high. Changing it to any value less than or equal to 32768 bytes (=32KiB) would fix the problem.I think a cleaner solution is to use the default package size from
pkg/sftp
, which is 32768 bytes. The MaxPacket parameter is no longer required when creating a new SFTP client.