Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default max packet size for SFTP #65

Merged
merged 1 commit into from Sep 25, 2018
Merged

Use default max packet size for SFTP #65

merged 1 commit into from Sep 25, 2018

Conversation

busser
Copy link

@busser busser commented Aug 22, 2018

This pull request changes nmon2influxdb so it uses the default MaxPacket size from from pkg/sftp.

A change to pkg/sftp (this commit) made in January broke nmon2influxdb's capacity to fetch remote files.

The reason is that the MaxPacket size used by nmon2influxdb, 64000 bytes, is too high. Changing it to any value less than or equal to 32768 bytes (=32KiB) would fix the problem.

I think a cleaner solution is to use the default package size from pkg/sftp, which is 32768 bytes. The MaxPacket parameter is no longer required when creating a new SFTP client.

@adejoux adejoux merged commit 8a5f061 into adejoux:master Sep 25, 2018
@adejoux
Copy link
Owner

adejoux commented Sep 25, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants