Skip to content

Push docs & where changes #79

Merged
merged 3 commits into from Apr 13, 2013

4 participants

@deanpcmad

I'm using Parse in my Rails application and I was going to build a Parse ruby client before I found this gem.
I've added some basic docs on Push notifications and I've also changed the way the where option works.
It works in my application fine and I can filter what notifications go to who now.
Hope this helps :smile:

@adelevie
Owner

This says the build failed:

Could you ensure the tests pass. If the README changes don't depend on the slightly modified API, I'd happily merge those in ASAP.

Thanks for helping with this!

@deanpcmad

OK done and the test is now passing

@adelevie
Owner

Great, thanks for working through this! I really appreciate the contribution!

@adelevie adelevie merged commit 0a5e9e5 into adelevie:master Apr 13, 2013

1 check passed

Details default The Travis build passed
@ericcj ericcj commented on the diff Apr 22, 2013
lib/parse/push.rb
@@ -14,6 +14,7 @@ class Push
def initialize(data, channel = "")
@data = data
@channel = channel
+ @where = where
@ericcj
ericcj added a note Apr 22, 2013

this line appears to be a noop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@dukedave

Hmm, why was this removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.