lots of fixes, read the commit messages #82

Merged
merged 5 commits into from Apr 22, 2013

3 participants

@Abdur

Those tests should be fixed, but if you are going to skip them, ship it.

@adelevie
Owner

Not sure I quite follow what problem this is aiming to solve...

neither of those tests pass if you clear their vcr fixtures and re-run them. it should always be safe to clear vcr and re-run, so it means the tests are broken. the cloud one should just have better automation to get the cloud function in place before testing. i tried to do it but couldn't figure out how. the relation one may actually be a bug, not sure

Owner

Gotcha. Not sure how automating the Cloud testing would work, but I'll look into it. Thanks for all the fixes!

we commit the parse binary to our source tree just to automate deploying it during tests. if we found that distasteful here we could provide a rake task to do it and document that in how to set up a dev environment

Owner

That seems alright? If you think pros outweigh the cons, I'm fine with it.

@adelevie
Owner

This is really cool!

@adelevie adelevie merged commit c518e2d into adelevie:master Apr 22, 2013

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment