Change rcov to simplecov #87

Merged
merged 2 commits into from Apr 29, 2013

Conversation

Projects
None yet
3 participants
@chytreg
Contributor

chytreg commented Apr 27, 2013

Rcov can run only on ruby 1.8.7 see issue: #86

@chytreg

This comment has been minimized.

Show comment Hide comment
@chytreg

chytreg Apr 27, 2013

Contributor

Coverage is optional enable via ENV variable

COVERAGE=true bundle exec rake
Contributor

chytreg commented Apr 27, 2013

Coverage is optional enable via ENV variable

COVERAGE=true bundle exec rake
Gemfile
@@ -1,20 +1,20 @@
-source "http://rubygems.org"
+source 'http://rubygems.org'

This comment has been minimized.

Show comment Hide comment
@jamonholmgren

jamonholmgren Apr 27, 2013

Probably be a good time to switch to https.

@jamonholmgren

jamonholmgren Apr 27, 2013

Probably be a good time to switch to https.

This comment has been minimized.

Show comment Hide comment
@adelevie

adelevie Apr 27, 2013

Owner

Pull request plz

Sent from my iPhone

On Apr 27, 2013, at 1:49 PM, Jamon Holmgren notifications@github.com wrote:

In Gemfile:

@@ -1,20 +1,20 @@
-source "http://rubygems.org"
+source 'http://rubygems.org'
Probably be a good time to switch to https.


Reply to this email directly or view it on GitHub.

@adelevie

adelevie Apr 27, 2013

Owner

Pull request plz

Sent from my iPhone

On Apr 27, 2013, at 1:49 PM, Jamon Holmgren notifications@github.com wrote:

In Gemfile:

@@ -1,20 +1,20 @@
-source "http://rubygems.org"
+source 'http://rubygems.org'
Probably be a good time to switch to https.


Reply to this email directly or view it on GitHub.

This comment has been minimized.

Show comment Hide comment
@jamonholmgren

jamonholmgren Apr 27, 2013

Sure.

This comment has been minimized.

Show comment Hide comment
@jamonholmgren

jamonholmgren Apr 27, 2013

Although you'll probably want to merge this one before I do that.

@jamonholmgren

jamonholmgren Apr 27, 2013

Although you'll probably want to merge this one before I do that.

This comment has been minimized.

Show comment Hide comment
@chytreg

chytreg Apr 27, 2013

Contributor

I can make commit with https change to this pull request.

@chytreg

chytreg Apr 27, 2013

Contributor

I can make commit with https change to this pull request.

This comment has been minimized.

Show comment Hide comment
@jamonholmgren

jamonholmgren Apr 27, 2013

👍

adelevie added a commit that referenced this pull request Apr 29, 2013

@adelevie adelevie merged commit ce3d01c into adelevie:master Apr 29, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment