Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add Ordering & Simplify Testing for Local Environments #47

Merged
merged 5 commits into from Oct 29, 2012

Conversation

Projects
None yet
2 participants
Contributor

mattvv commented Oct 29, 2012

Hey Alan,

I added support for the ordering query and added tests to support this use case. I also cleaned up the variables for local testing, since it seems you hardcoded it for travis CI, it should now work on both local and travis CI as per the instructions.

Owner

adelevie commented Oct 29, 2012

Thanks a lot for fixing this--it's been a monkey on my back for a little while.

I'll be AFK for at least a couple days due to some Hurricane-related stuff, but ill take a look ASAP and merge.

Move Ordering Tests into appropriate area
Move Ordering tests to parse_resoruce tests.
Contributor

mattvv commented Oct 29, 2012

no problem, hope everything is ok over there! I

Owner

adelevie commented Oct 29, 2012

Haha thanks. I'm doing fine, just separated from my computer for the time being.

Do you know why the test is failing on Travis?

Sent from my iPhone

On Oct 29, 2012, at 7:25 PM, Matt Van notifications@github.com wrote:

no problem, hope everything is ok over there! I


Reply to this email directly or view it on GitHub.

Contributor

mattvv commented Oct 29, 2012

Not entirely sure, Everything passes just fine on mine - I think it may be an issue with stale state of test environment as it is an unrelated test failing (Events table may not be clean from previous builds)

Owner

adelevie commented Oct 29, 2012

Alright. Your word is good here. Ill merge it in and fix the test suite when this hurricane subsides.

Sent from my iPhone

On Oct 29, 2012, at 7:28 PM, Matt Van notifications@github.com wrote:

Not entirely sure, Everything passes just fine on mine - I think it may be an issue with stale state of test environment as it is an unrelated test failing (Events table may not be clean from previous builds)


Reply to this email directly or view it on GitHub.

adelevie added a commit that referenced this pull request Oct 29, 2012

Merge pull request #47 from mattvv/master
Add Ordering & Simplify Testing for Local Environments

@adelevie adelevie merged commit 0332bed into adelevie:master Oct 29, 2012

1 check was pending

default The Travis build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment