ClearSight merge #69
Merged
ClearSight merge #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I'm having a couple test fail on Travis.ci. It works locally. I'll have to fix tomorrow. |
|
The tests pass now with flying colors (and take less than 2 seconds on my machine, by the way). :) Waiting on @adelevie's approval. |
|
We should probably increment the version number. I would recommend 1.8.0. |
|
Thanks Alan! |
|
!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a ton of work making sure that everything worked well together (several hours worth). I have decent coverage on the tests and they pass in under two seconds.
I think it's good to merge. The main feature additions are the batch save/delete and chunking parts plus the date and upload features work better.