Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excon-Adapter #38

Merged
merged 4 commits into from Jan 7, 2018
Merged

Excon-Adapter #38

merged 4 commits into from Jan 7, 2018

Conversation

@manme
Copy link

@manme manme commented Dec 17, 2017

Integration of Excon for Sniffer is introduced here

Mikhail Mandronov added 4 commits Dec 17, 2017
Mikhail Mandronov
Mikhail Mandronov
Mikhail Mandronov
# rubocop:disable Metrics/AbcSize,Metrics/MethodLength
def request_with_sniffer(params = {}, &block)
if Sniffer.enabled?
datum = data.merge(params)

This comment has been minimized.

@manme

manme Dec 18, 2017
Author

возможно не лучшая имплементация
данные о запросе могут храниться как в data так и в params
через middleware в теории может быть стабильней, но для других адаптеров выбран подобный путь.

This comment has been minimized.

@aderyabin

aderyabin Jan 7, 2018
Owner

Потому что не все поддерживают middleware

@aderyabin aderyabin merged commit 7d0cb5c into aderyabin:master Jan 7, 2018
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@palkan
Copy link
Contributor

@palkan palkan commented Aug 2, 2019

Hey @manme!

Could you please send me your actual email address to palkan@evl.ms? We're collecting CultOfMartians participants contact info (to ping you later and ask where we can send some merch for you 🙂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants