Excon-Adapter #38
Merged
Excon-Adapter #38
Conversation
| # rubocop:disable Metrics/AbcSize,Metrics/MethodLength | ||
| def request_with_sniffer(params = {}, &block) | ||
| if Sniffer.enabled? | ||
| datum = data.merge(params) |
manme
Dec 18, 2017
Author
возможно не лучшая имплементация
данные о запросе могут храниться как в data так и в params
через middleware в теории может быть стабильней, но для других адаптеров выбран подобный путь.
возможно не лучшая имплементация
данные о запросе могут храниться как в data так и в params
через middleware в теории может быть стабильней, но для других адаптеров выбран подобный путь.
aderyabin
Jan 7, 2018
Owner
Потому что не все поддерживают middleware
Потому что не все поддерживают middleware
|
Hey @manme! Could you please send me your actual email address to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Integration of Excon for Sniffer is introduced here