Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upExcon-Adapter #38
Conversation
added some commits
Dec 17, 2017
| # rubocop:disable Metrics/AbcSize,Metrics/MethodLength | ||
| def request_with_sniffer(params = {}, &block) | ||
| if Sniffer.enabled? | ||
| datum = data.merge(params) |
This comment has been minimized.
This comment has been minimized.
manme
Dec 18, 2017
возможно не лучшая имплементация
данные о запросе могут храниться как в data так и в params
через middleware в теории может быть стабильней, но для других адаптеров выбран подобный путь.
This comment has been minimized.
This comment has been minimized.
aderyabin
merged commit 7d0cb5c
into
aderyabin:master
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
manme commentedDec 17, 2017
Integration of Excon for Sniffer is introduced here