From 6076b87d0b29b9b3f4cfe72501d2002fe9296bf7 Mon Sep 17 00:00:00 2001
From: StephanH90 <88476449+StephanH90@users.noreply.github.com>
Date: Wed, 9 Aug 2023 11:06:31 +0200
Subject: [PATCH] fix: parse queryparams for magic link as booleans, not
 strings (#1046)

* fix: parse queryparam as boolean, not string

* fix: dont use strictEqual to check currentRoute in test
---
 app/index/reports/controller.js        | 4 ++--
 tests/acceptance/index-reports-test.js | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/index/reports/controller.js b/app/index/reports/controller.js
index 99a966d46..279d6d909 100644
--- a/app/index/reports/controller.js
+++ b/app/index/reports/controller.js
@@ -24,8 +24,8 @@ export default class IndexReportController extends Controller {
   @tracked task;
   @tracked duration;
   @tracked comment;
-  @tracked review;
-  @tracked notBillable;
+  @tracked review = false;
+  @tracked notBillable = false;
 
   @service notify;
   @service router;
diff --git a/tests/acceptance/index-reports-test.js b/tests/acceptance/index-reports-test.js
index b614f380f..8d6441319 100644
--- a/tests/acceptance/index-reports-test.js
+++ b/tests/acceptance/index-reports-test.js
@@ -182,7 +182,7 @@ module("Acceptance | index reports", function (hooks) {
     await click(`button[data-date="${tomorrow}"]`);
     await click("[data-test-report-save]");
 
-    assert.strictEqual(currentURL(), `/reports?day=${tomorrow}`);
+    assert.ok(currentURL().includes(`/reports?day=${tomorrow}`));
     assert.dom("[data-test-report-row]").exists({ count: 6 });
   });
 });