Restart the DRB service when it completes it’s thread #7
Conversation
|
Rebased with changelog and specs... should be ready to merge now, pending your review @benlangfeld |
|
Hmm, travis says no... I'll figure out why these are passing at home with different rubies and failing on Travis, better not merge this until CI is fixed. |
Unless it’s explicitly stopped by the user
|
Yay green! Just needed a little pause to allow the DRB process time to restart; guess Travis's VMs aren't as speedy as a mighty Mac. Should be clear to merge now. |
| acl = create_acl config.acl.allow, config.acl.deny | ||
| def initialize | ||
| @user_stopped = false | ||
| Thread.abort_on_exception = true |
There was a problem hiding this comment.
I'm not so sure about including this here, since it's global. Necessary?
There was a problem hiding this comment.
Removed in commit below.
|
Did you manage to test this in a real app (perhaps by implementing something in the server object which raises when called)? |
|
Raising exceptions in the server object never breaks the DRB thread that I can find.. but I tried setting up a method in the DRB object that closed the drb connection directly, and whenever calling that, this restarts it successfully in the real app. |
|
Go ahead and merge/release as soon as Travis says yes. You have authorship on the gem. |
Restart the DRB service when it completes it’s thread
Unless it’s explicitly stopped by the user