Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording completion callback after on_end #501

Open
system123 opened this issue Jul 9, 2014 · 2 comments
Open

Recording completion callback after on_end #501

system123 opened this issue Jul 9, 2014 · 2 comments

Comments

@system123
Copy link

The call recording completion callback is fired after the call on_end handler. This is a problem as it means the call on_end handler cannot perform operations on the recording URL as it is only returned after the on_end handler.

Issue was described here: https://groups.google.com/forum/#!topic/adhearsion/jhIj4UPkgM0

Code which should be able to recreate the issue is here:
https://gist.github.com/system123/93c5c24e73fff17e54fe

@benlangfeld
Copy link
Member

I suspect this example might be minimised to eliminate the second call, replacing it with a sleep.

Additionally, I would appreciate full TRACE level logs of such a reproduction.

@system123
Copy link
Author

I have updated the Gist to include a TRACE log, I also updated my example to one which reproduces the problem. Removing the second call and using sleep instead as well as moving the start recording out of the on_joined callback did not produce the issue. It seems it is only reproduced in when setup with a second call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants