Skip to content

Only support Ruby 2.2+ and JRuby 9.0.0.0+#552

Merged
benlangfeld merged 1 commit intodevelopfrom
feature/ruby-version-support
Jun 19, 2015
Merged

Only support Ruby 2.2+ and JRuby 9.0.0.0+#552
benlangfeld merged 1 commit intodevelopfrom
feature/ruby-version-support

Conversation

@benlangfeld
Copy link
Member

Drop attempts at support for Rubinius

@benlangfeld benlangfeld added this to the 3.0.0 milestone Jun 15, 2015
@bklang
Copy link
Member

bklang commented Jun 15, 2015

Does JRuby 1.7 support Ruby 2.2 syntax?

@benlangfeld
Copy link
Member Author

No, that is why I specified JRuby 9.0.0.0+

@emcgee
Copy link

emcgee commented Jun 15, 2015

FYI, I've seen a lot of segfault errors with Ruby 2.2.2 - celluloid/celluloid#625 (comment)

A simple reproduction was just to let ahn connect via Rayo to FS and then just idle. Eventually it would die with the error described above.

Haven't had time to dig further into it and report a bug back to ruby-lang or similar.

.travis.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no 2.2.0 or 2.2.1 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@JustinAiken
Copy link
Member

I like it! Rails 5 and Adhearsion 3, helping kill off old Rubies one travis matrix at a time!

@benlangfeld benlangfeld force-pushed the feature/ruby-version-support branch from ab78d7c to d38bb3f Compare June 16, 2015 17:11
@benlangfeld
Copy link
Member Author

@emcgee I'm blocking this on #527. Hopefully that should help. I'd appreciate your feedback again once that is done.

@benlangfeld benlangfeld force-pushed the feature/ruby-version-support branch from d38bb3f to 817f479 Compare June 19, 2015 19:07
@benlangfeld
Copy link
Member Author

@emcgee The upgrade to Celluloid 0.16 is complete, and so this is now unblocked. I'd appreciate your feedback on how things look now.

@emcgee
Copy link

emcgee commented Jun 19, 2015

@benlangfeld I'll put this onto a staging server immediately that sees light usage and monitor it.

@bklang
Copy link
Member

bklang commented Jun 19, 2015

@emcgee Heads up that Adhearsion's develop branch is now Adhearsion 3 and contains breaking changes. If you want to test this, make sure you're using the support/2.x.x branch.

@benlangfeld Did the appropriate merge get to support/2.x.x? Is that even possible?

@benlangfeld
Copy link
Member Author

No, support/2.x.x will not receive these changes, as this would require coordination with Punchblock versioning.

@emcgee
Copy link

emcgee commented Jun 19, 2015

@bklang Not a problem - saw those changes and I'll make the modifications on this side. Who am I to stand in the way of progress.

@benlangfeld benlangfeld force-pushed the feature/ruby-version-support branch from 817f479 to 260764b Compare June 19, 2015 19:35
Drop attempts at support for Rubinius
@benlangfeld benlangfeld force-pushed the feature/ruby-version-support branch from 260764b to cfbbca4 Compare June 19, 2015 19:36
benlangfeld added a commit that referenced this pull request Jun 19, 2015
Only support Ruby 2.2+ and JRuby 9.0.0.0+
@benlangfeld benlangfeld merged commit 062c15f into develop Jun 19, 2015
@benlangfeld benlangfeld deleted the feature/ruby-version-support branch June 19, 2015 20:21
@emcgee
Copy link

emcgee commented Jun 23, 2015

@benlangfeld Follow up on this - I ran a stripped down version of our platform on this for the last 4 days on 2.2.2 with no random segfaults. Much other was broken, naturally, but calls completed as ussual with no issues. I'd consider celluloid/celluloid#625 (comment) to be closed by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants