Skip to content


Subversion checkout URL

You can clone with
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: adhearsion/nokogiri
head fork: adhearsion/nokogiri
Commits on Oct 05, 2012
@benlangfeld benlangfeld [FEATURE] XPath lookup with namespaces with hash keys 44d1c3e
@benlangfeld benlangfeld [FEATURE] XML::Node#[]= should stringify values 9973cc4
@flavorjones flavorjones Merge pull request #729 from adhearsion/feature/misc
XPath lookup with namespaces with hash keys and XML::Node#[]= should stringify values
@flavorjones flavorjones CHANGELOG fe3c5ed
Commits on Oct 06, 2012
@tenderlove tenderlove Documents can be piped to the nokogiri command line tool 218903d
Commits on Oct 12, 2012
@flavorjones flavorjones Removing an unnecessary Node#key? call from Node#[]
Thanks to Ben Langfeld for pointing this out.
@benlangfeld benlangfeld [BUG] Setting attributes on XML nodes using #[]= does not set namespa…
…ce on JRuby
@benlangfeld benlangfeld [BUG] Add further test coverage to setting attributes with a namespac…
…e prefix
@flavorjones flavorjones cleanup 6df19f2
Commits on Oct 16, 2012
@flavorjones flavorjones README. Closes #777 4229826
Commits on Oct 21, 2012
@jvshahid jvshahid Fix issue #770.
DocumentFragment parsing which depends on Xml::Node::parse didn't
properly handle namespaces in context. Ideally we should be using
Xerces parsing with a hint to the context node, but unfortunately
this feature isn't implemented yet which is why we
manually add namespace declarations to the fake root that encapsulates
the document fragment.
@jvshahid jvshahid Fix the failing test that was added by PR #726 related to issue #712. 7e9b209
@jvshahid jvshahid add documentation to point to the issue that required the changes. d41d950
@jvshahid jvshahid fixes #775.
libxml will throw an error if we tried to replace a text node
in a document fragment since it tries to find an element node
or a document node in the parents of the node being replaced.
To make this possible we add an element node and replace that
node instead.
Commits on Oct 22, 2012
@flavorjones flavorjones Cleanup in preparation for adding complexity. dfca834
@flavorjones flavorjones More efficient implementation of fix from #726 for #712. a4bd937
@flavorjones flavorjones Merge branch 'my-version-of-pr-726' 765d8dd
@flavorjones flavorjones Make the last commit's code more readable (related to #726 and #712) 9360ccc
Commits on Oct 24, 2012
@jvshahid jvshahid Changing some fields to final since we don't modify them. 5c49788
@jvshahid jvshahid add xml declaration, otherwise Xerces will complain that the document…
… is prematurely ending.
@jvshahid jvshahid make test_processing_instruction pass. 557e674
Commits on Oct 25, 2012
@jvshahid jvshahid fix #781.
Wrapping a Java Document in a XmlDocument didn't initialize the instance
varaibles which caused the Xml::Node::parse method to throw an error when
trying to access the errors iv.
Commits on Nov 09, 2012
@jvshahid jvshahid fixes #495
Xerces will close the InputSource which closes the InputStream of the RubyIO
that was passed to Nokogiri::XML. This closes the underlying FileDescriptor
that is maintained internally by JRuby while the RubyIO object is still
referencing it, which causes a BadFileDescriptor when RubyIO#close is called.
Something went wrong with that request. Please try again.