Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Concatenated documents should have at least one space separating the strings #21

Closed
bklang opened this Issue Feb 21, 2014 · 1 comment

Comments

Projects
None yet
2 participants
Owner

bklang commented Feb 21, 2014

Example:

s1 = RubySpeech::SSML.draw { 'thing 1' }
p s1

s2 = RubySpeech::SSML.draw { 'thing 2' }
p s2

# Concatenate
p s1 + s2

yields:

<speak xmlns="http://www.w3.org/2001/10/synthesis" version="1.0" xml:lang="en-US">thing 1</speak>
<speak xmlns="http://www.w3.org/2001/10/synthesis" version="1.0" xml:lang="en-US">thing 2</speak>
<speak xmlns="http://www.w3.org/2001/10/synthesis" version="1.0" xml:lang="en-US">thing 1thing 2</speak>

This would throw off most speech engines. I think the default should be more like:

<speak xmlns="http://www.w3.org/2001/10/synthesis" version="1.0" xml:lang="en-US">thing 1 thing 2</speak>

benlangfeld added a commit that referenced this issue Feb 24, 2014

Owner

benlangfeld commented Feb 24, 2014

v2.3.1 is out with this fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment