From 4d4c192e0994ff7849641499b728fe228ae66a4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= Date: Tue, 3 Jan 2023 15:22:38 +0000 Subject: [PATCH] [FIX] spreadsheet_dashboard: unskip expense dashboard test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test was skipped because the expense dashboard was broken when the test was merged. See https://github.com/odoo/odoo/commit/17afe2987e4146b85187b31a34caf7146d5a7cf2 closes odoo/odoo#109017 Signed-off-by: Rémi Rahir (rar) --- addons/spreadsheet_dashboard/tests/test_dashboard_data.py | 7 ------- .../data/files/expense_dashboard.json | 8 -------- 2 files changed, 15 deletions(-) diff --git a/addons/spreadsheet_dashboard/tests/test_dashboard_data.py b/addons/spreadsheet_dashboard/tests/test_dashboard_data.py index aeb7ad5de023c..8b7cdbab69e58 100644 --- a/addons/spreadsheet_dashboard/tests/test_dashboard_data.py +++ b/addons/spreadsheet_dashboard/tests/test_dashboard_data.py @@ -10,12 +10,5 @@ def test_validate_dashboard_data(self): """validate fields and models used in dashboards""" dashboards = self.env["spreadsheet.dashboard"].search([]) for dashboard in dashboards: - # this dashboard is skipped because it's currently broken - # but I still want to merge this test right now to avoid other broken dashboards - if dashboard == self.env.ref( - "spreadsheet_dashboard_hr_expense.spreadsheet_dashboard_expense", - raise_if_not_found=False, - ): - continue with self.subTest(dashboard.name): self.validate_spreadsheet_data(dashboard.raw, dashboard.name) diff --git a/addons/spreadsheet_dashboard_hr_expense/data/files/expense_dashboard.json b/addons/spreadsheet_dashboard_hr_expense/data/files/expense_dashboard.json index d999594dd0bab..e819c56723dfa 100644 --- a/addons/spreadsheet_dashboard_hr_expense/data/files/expense_dashboard.json +++ b/addons/spreadsheet_dashboard_hr_expense/data/files/expense_dashboard.json @@ -1040,10 +1040,6 @@ "8": { "field": "product_id", "type": "many2one" - }, - "9": { - "field": "product_id", - "type": "many2one" } }, "listFields": { @@ -1092,10 +1088,6 @@ "8": { "field": "employee_id", "type": "many2one" - }, - "9": { - "field": "employee_id", - "type": "many2one" } }, "listFields": {