refactor a bit get_config and adding simple test

Author: adhorn

python/chaos_lib.py

@@ -22,9 +22,6 @@ def request(self, method, url, **kwargs):
         time.sleep(self.delay / 1000.0)
         return super(SessionWithDelay, self).request(method, url, **kwargs)
 
-    def close(self):
-        self.session.close()
-
 
 def get_config(config_key):
     param = SSMParameter(os.environ['FAILURE_INJECTION_PARAM'])
@@ -36,11 +33,11 @@ def get_config(config_key):
         key_ = value[config_key]
         return key_
     except InvalidParameterError as e:
-        print("{} does not exist in SSM".format(e))
-        raise InvalidParameterError
+        # key does not exist in SSM
+        raise InvalidParameterError("{} does not exist in SSM".format(e))
     except KeyError as e:
-        print("{} is not a valid Key in the SSM configuration".format(e))
-        raise KeyError
+        # not a valid Key in the SSM configuration
+        raise KeyError("{} is not a valid Key in the SSM configuration".format(e))
 
 
 def corrupt_delay(func):
@@ -76,7 +73,6 @@ def wrapper(*args, **kwargs):
         print("exception_msg from config {}".format(exception_msg))
         print("corrupting now")
         raise Exception(exception_msg)
-        return result
     return wrapper
 
 

python/test.py

@@ -0,0 +1,66 @@
+from chaos_lib import get_config
+from ssm_cache import InvalidParameterError
+import unittest
+import os
+import warnings
+import boto3
+
+client = boto3.client('ssm', region_name='eu-north-1')
+
+
+def ignore_warnings(test_func):
+    def do_test(self, *args, **kwargs):
+        with warnings.catch_warnings():
+            warnings.simplefilter("ignore", ResourceWarning)
+            warnings.simplefilter("ignore", DeprecationWarning)
+            test_func(self, *args, **kwargs)
+    return do_test
+
+
+class TestStringMethods(unittest.TestCase):
+
+    @ignore_warnings
+    def setUp(self):
+        os.environ['FAILURE_INJECTION_PARAM'] = 'test.config'
+        client.put_parameter(
+            Value="{ \"delay\": 200, \"isEnabled\": true, \"error_code\": 404, \"exception_msg\": \"I FAILED\"}",
+            Name='test.config',
+            Type='String',
+            Overwrite=True
+        )
+
+    @ignore_warnings
+    def tearDown(self):
+        client.delete_parameters(Names=['test.config'])
+
+    @ignore_warnings
+    def test_get_config(self):
+        isEnabled = get_config('isEnabled')
+        self.assertEqual(isEnabled, True or False)
+
+    @ignore_warnings
+    def test_get_config_delay(self):
+        delay = get_config('delay')
+        self.assertEqual(delay, 200)
+
+    @ignore_warnings
+    def test_get_config_error_code(self):
+        delay = get_config('error_code')
+        self.assertEqual(delay, 404)
+
+    @ignore_warnings
+    def test_get_config_bad_key(self):
+        with self.assertRaises(KeyError):
+            get_config('dela')
+
+    @ignore_warnings
+    def test_get_config_bad_config(self):
+        os.environ['FAILURE_INJECTION_PARAM'] = 'test.conf'
+        with self.assertRaises(InvalidParameterError):
+            get_config('delay')
+
+
+
+
+if __name__ == '__main__':
+    unittest.main()