Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkmate bug fix breaks unit test #73

Closed
mllg opened this issue Nov 28, 2018 · 2 comments
Closed

checkmate bug fix breaks unit test #73

mllg opened this issue Nov 28, 2018 · 2 comments

Comments

@mllg
Copy link

@mllg mllg commented Nov 28, 2018

I've recently discovered and fixed a bug w.r.t. missing checks in lists in mllg/checkmate#146. The bugfix now tests lists for elements being identical to NULL which comes closest to a "missing" in lists, but this unfortunately breaks a unit test in your package. Before the fix, the test was defunct and did not trigger any check at all.

Could you please check your assertions accordingly with the devel release of checkmate? I'll prepare a new release of checkmate and want to upload soon.

This is the relevant part of the check log:

  ── 1. Failure: Formula special 'func' works as expected (@test-specials.R#6)  ──
  Check on cumu1 isn't true.
  Contains missing values (element 4)
  
  ── 2. Failure: Formula special 'concurrent' works as expected (@test-specials.R#
  Check on ccr1 isn't true.
  Contains missing values (element 3)
  
  ══ testthat results  ═══════════════════════════════════════════════════════════
  OK: 279 SKIPPED: 0 FAILED: 2
  1. Failure: Formula special 'func' works as expected (@test-specials.R#6) 
  2. Failure: Formula special 'concurrent' works as expected (@test-specials.R#18) 

Sorry for the inconvenience.

@fabian-s
Copy link
Collaborator

@fabian-s fabian-s commented Nov 28, 2018

@mllg: thx for the great package. Andi will look at the PR shortly, I guess.

@adibender adibender closed this in 37a9862 Nov 28, 2018
adibender added a commit that referenced this issue Nov 28, 2018
closes #73: checkmate now counts NULL as missing in lists.
@adibender
Copy link
Owner

@adibender adibender commented Nov 28, 2018

thx for notification @mllg and thx for fixing @fabian-s
I've merged the branch. Will fix a couple of other things and resubmit to CRAN in approx. 2 weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.