Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Call Fails If Streamer Doesn't Have 7tv Emotes When Using 7tv/all Service Call #1

Closed
imbedhead opened this issue Feb 1, 2022 · 2 comments · Fixed by #2
Closed

Comments

@imbedhead
Copy link

May be an edge case, but if a streamer doesn't have 7tv emotes for their channel while making an API request including "7tv" (or using "all") for the service parameter, the request will result in a 502 error. This can be replicated via the API request test found on https://adiq.stoplight.io/docs/temotes/b3A6MzI2NTc0MjI-get-channel-emotes using the following parameters:

Case #1:
channel: imbedhead
services: twitch
results: Response code 200, with an empty array
Case #2:
channel: imbedhead
services: bttv
results: Response code 200, with an empty array
Case #3:
channel: imbedhead
services: 7tv
results: Response code 502, no results
Case #4:
channel: imbedhead
services: all
results: Response code 502, no results

A better case could be using streamer "imaqtpie", who has twitch, bttv, and ffz emotes, but not 7tv emotes, causing the issue mentioned above.

Also wanted to say love the api! Exactly what I needed for my own little project.

@adiq
Copy link
Owner

adiq commented Feb 3, 2022

Hey @imbedhead!
Thanks for the kind words.

I appreciate your detailed report and promise to look into this issue soon 😉

@adiq
Copy link
Owner

adiq commented Feb 3, 2022

Issue fixed 🎉 If a user does not use any service, an empty array will be returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants