Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Improvements #417

Closed
erohtar opened this issue Jan 12, 2022 · 9 comments
Closed

Settings Improvements #417

erohtar opened this issue Jan 12, 2022 · 9 comments

Comments

@erohtar
Copy link

erohtar commented Jan 12, 2022

These are rather low priority, but would be nice to have when you have a free moment..

  • The Settings window loses its custom size when FS is exited and reloaded (though it retains it during the session). Would be nice if it stuck.
  • It's really cool that FS provides a very easy way to change the Font throughout the app, though if the font selection list had the fonts actually listed in that actual font, it'd get much easier to pick the right one. (If this leads to increase in memory consumption, best would be to load/unload those fonts only when displaying that list)

Cheers!

@adirh3
Copy link
Owner

adirh3 commented Jan 12, 2022

Thanks for the feedback @RAJAT-R!

  1. You can retain the Settings window size by enabling Keep window size after restart in Settings -> Appearance (advanced)
  2. Not sure what you mean by "actual font", are the Fonts shown in Settings -> Appearance -> Font family misses some fonts you have installed in Windows?

@erohtar
Copy link
Author

erohtar commented Jan 12, 2022

Hey @adirh3 !

  1. Yes I already have that enabled. Maybe it matters that I'm running FS portable?
  2. No I don't mean some fonts are missing - here, let me explain via pictures

This is FS
image

This is another app
image

(but like I said, low priority - just a nice to have feature, not need to have)

@adirh3
Copy link
Owner

adirh3 commented Jan 12, 2022

Hey @adirh3 !

  1. Yes I already have that enabled. Maybe it matters that I'm running FS portable?
  2. No I don't mean some fonts are missing - here, let me explain via pictures

This is FS image

This is another app image

(but like I said, low priority - just a nice to have feature, not need to have)

Oh, you're using the nightly version? The height not saving is a bug, will fix it in today's update.
Now I understand what you mean about the font, thanks for the images. Will change it soon.
Thanks!

@erohtar
Copy link
Author

erohtar commented Jan 12, 2022

Oh, you're using the nightly version?

Yes! I want the latest and greatest! Also, can't have you telling me it's already fixed hahha

@adirh3
Copy link
Owner

adirh3 commented Jan 12, 2022

This issue has been potentially fixed in version 0.9.90.96

1 similar comment
@adirh3
Copy link
Owner

adirh3 commented Jan 12, 2022

This issue has been potentially fixed in version 0.9.90.96

@erohtar
Copy link
Author

erohtar commented Jan 13, 2022

Wow @adirh3! You're sure lightning fast! I just tested them out and the improvements look amazing!

I'm going to put this one just here, because it's very related to the above fonts update. I noticed that the font scale slider is very difficult to work with - it jumps the whole UI when you try to move it using mouse (because it tries to update in realtime, while it should wait for the mouse button to let go first), and it doesn't work if I try to click on it and use the keyboard left/right to update it.

You could add the aforementioned wait to fix the issue, or maybe replace the slider with a control like this?
image

@adirh3
Copy link
Owner

adirh3 commented Jan 14, 2022

This issue has been potentially fixed in version 0.9.90.97

@erohtar
Copy link
Author

erohtar commented Jan 14, 2022

Works perfectly now, thank you!

@erohtar erohtar closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants