Add RSS icon to archive pages#1156
Merged
adityatelange merged 1 commit intoadityatelange:masterfrom Apr 1, 2023
Merged
Conversation
If the setting “ShowRssButtonInSectionTermList” is true, I think it makes sense to also show the RSS icon by the title in archive pages, as we do for other article lists. This reuses the code of `layouts/_default/list.html`.
|
Kudos, SonarCloud Quality Gate passed!
|
adityatelange
approved these changes
Apr 1, 2023
adityatelange
added a commit
that referenced
this pull request
Apr 1, 2023
This reverts commit a636c9e.
adityatelange
added a commit
that referenced
this pull request
Apr 1, 2023
Contributor
Author
|
I see you have reverted the change @adityatelange, is it because something is broken? I’m happy to investigate if you want. |
jdxgfty
pushed a commit
to jdxgfty/hugo-PaperMod
that referenced
this pull request
Nov 3, 2024
If the setting “ShowRssButtonInSectionTermList” is true, I think it makes sense to also show the RSS icon by the title in archive pages, as we do for other article lists. This reuses the code of `layouts/_default/list.html`.
jdxgfty
pushed a commit
to jdxgfty/hugo-PaperMod
that referenced
this pull request
Nov 3, 2024
…lange#1183) This reverts commit 8b2ec86.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
If the setting “ShowRssButtonInSectionTermList” is true, I think it
makes sense to also show the RSS icon by the title in archive pages, as
we do for other article lists.
Tested on my website:
This reuses the code of
layouts/_default/list.html.Was the change discussed in an issue or in the Discussions before?
Not that I’m aware.
PR Checklist