Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSS icon to archive pages #1156

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Feb 11, 2023

What does this PR change? What problem does it solve?

If the setting “ShowRssButtonInSectionTermList” is true, I think it
makes sense to also show the RSS icon by the title in archive pages, as
we do for other article lists.

Tested on my website:
image

This reuses the code of layouts/_default/list.html.

Was the change discussed in an issue or in the Discussions before?

Not that I’m aware.

PR Checklist

  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.

If the setting “ShowRssButtonInSectionTermList” is true, I think it
makes sense to also show the RSS icon by the title in archive pages, as
we do for other article lists.

This reuses the code of `layouts/_default/list.html`.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

@adityatelange adityatelange merged commit a636c9e into adityatelange:master Apr 1, 2023
adityatelange added a commit that referenced this pull request Apr 1, 2023
adityatelange added a commit that referenced this pull request Apr 1, 2023
@cljoly
Copy link
Contributor Author

cljoly commented Apr 1, 2023

I see you have reverted the change @adityatelange, is it because something is broken? I’m happy to investigate if you want.

jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
If the setting “ShowRssButtonInSectionTermList” is true, I think it
makes sense to also show the RSS icon by the title in archive pages, as
we do for other article lists.

This reuses the code of `layouts/_default/list.html`.
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants