Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svg icon for ycombinator #535

Merged
merged 2 commits into from Sep 5, 2021

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Aug 27, 2021

What does this PR change? What problem does it solve?

  • YCombinator icon is useful to link to one’s Hacker News profile.

  • CC0 from simpleicons.org.

  • Changed fill argument to adapt to light and dark theme.

Was the change discussed in an issue or in the Discussions before?
No

PR Checklist

  • I have enabled maintainer edits for this PR.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.

cljoly and others added 2 commits August 27, 2021 21:58
YCombinator icon is useful to link to one’s Hacker News profile.

CC0 from simpleicons.org.

Changed fill argument to adapt to light and dark theme.
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange merged commit 8021be2 into adityatelange:master Sep 5, 2021
@cljoly
Copy link
Contributor Author

cljoly commented Sep 5, 2021

Thanks

No worries, thanks a lot for maintaining this awesome theme!

kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants