HEADERNAME may not start with '-'. #37

Merged
merged 2 commits into from Feb 24, 2015

Conversation

Projects
None yet
2 participants
@adl
Owner

adl commented Feb 24, 2015

Identifier may not start with -, so that --ABORT-- may not be mistaken as an identifier. And although we state that HEADERNAME are like identifiers followed by :, the given regex allows them to start with -. This raises the question of whether --ABORT--: is a HEADERNAME, or if is --ABORT-- followed by :.

I suggest we simply fix the HEADERNAME definition to disallow a leading -. This is what is implemented in Spot 1.99a and jhoafparser 1.0.1 already. (But maybe there is a development version of jhoafparser that recognizes -: as a HEADERNAME by now, because this is one case in the test-suite developed by Joachim.)

HEADERNAME may not start with '-'.
"t:" and "f:" are valid HEADERNAMEs.
@kleinj

This comment has been minimized.

Show comment
Hide comment
@kleinj

kleinj Feb 24, 2015

Collaborator

Yes, I think that allowing - at the start of the regex for HEADERNAME is just a typo. We should simply remove this. It's just a corner case that's tricky to implement in the parser and serves no purpose.

Collaborator

kleinj commented Feb 24, 2015

Yes, I think that allowing - at the start of the regex for HEADERNAME is just a typo. We should simply remove this. It's just a corner case that's tricky to implement in the parser and serves no purpose.

adl added a commit that referenced this pull request Feb 24, 2015

Merge pull request #37 from adl/headername
HEADERNAME may not start with '-'.

@adl adl merged commit ff053c1 into master Feb 24, 2015

@adl adl deleted the headername branch May 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment