added commands.phantomUploadFile :sunrise_over_mountains: #264

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

Whoaa512 commented Mar 3, 2014

This is dependant on detro/ghostdriver#324 and ariya/phantomjs#12030

Collaborator

sebv commented Mar 4, 2014

What does it add to the standard upload file mechanism, looks like a doublon with uploadFile?

Contributor

Whoaa512 commented Mar 4, 2014

It's different because it's intended to work with the ghostdriver/phantomjs pull requests mentioned above. Which expect a CSS selector of the file input and an absolute file path. 

The current implementation zips the file before making the POST request.

Originally I wanted to modify the existing uploadFile method, but it didn't  maintain the CSS selector if you went though sendKeys. 
Cheers,
CJ

On Mon, Mar 3, 2014 at 6:06 PM, seb vincent notifications@github.com
wrote:

What does it add to the standard upload file mechanism, looks like a doublon with uploadFile?

Reply to this email directly or view it on GitHub:
#264 (comment)

Collaborator

sebv commented Mar 4, 2014

Yeah I mean the ghostdriver/phantomjs pull requests probably does it wrong.

@sebv sebv added the new feature label Mar 29, 2014

Collaborator

sebv commented Apr 21, 2015

This should be a custom method.

@sebv sebv closed this Apr 21, 2015

Contributor

Whoaa512 commented Jul 31, 2015

@sebv, I'm trying to make this a custom method. I'm curious how would I go about accessing callbackWithData() from within a method added via wd.addAsyncMethod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment