-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LibXML2] Link LibXML2 Statically for Linux #1527
Conversation
Do we know this is a Linux problem as opposed to a wheel problem? If it's the latter we could just add an optional control (like checking an environment variable) to force static linking and then use that when building the wheels. |
571d154
to
04e9643
Compare
Can this please be made configurable? When packaging afdko for nixpkgs we can provide libxml2 via the package manager and be confident that it'll be available at runtime as well. What we don't want is to download and link a random version of libxml2 in when building afdko. |
3.9.1 is problematic atm because it'll unconditionally use the libxml2 externalproject on linux: adobe-type-tools/afdko#1527 (comment) https://github.com/adobe-type-tools/afdko/blob/3.9.0/NEWS.md#390-released-2022-06-23
The Linux restriction in this release is likely temporary -- we needed to do something like this to resolve the libxml2 problems in the previous release. We will probably start to revisit the specifics week after next. |
@sternenseemann I added an environment variable to the root CMakeLists.txt that should allow you to force linking against the system LibXML2 on Linux. If you just set it to anything CMake should find it. Give it a shot on your distro and if it doesn't work file an issue against afdko and I'll look at it. |
@skef thanks that works & we are able to update to 3.9.2 now. |
Description
Due to a bug in the linux python wheels involving dynamically linking libxml2, discovered in #1525 , we'll be installing libxml2 externally through
ExternalLibXML2.cmake
and linking statically, just like we do in most Windows cases.We will revisit this in the future and attempt to fix dynamic linking for linux.
Checklist: