Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix to use closeTag in brackets and addon for closeElement #76

Merged
merged 4 commits into from

2 participants

@deemeetar

This fix in the addon is needed so i could implement closeTag in brackets

The second commit is addon for autoclosing Parentheses, Brackets, and Braces

@RaymondLim
Collaborator

@deemeetar You're adding a new file into CodeMirror. So would you please submit your new file into upstream first since you're the original author of the new file?

And leave this pull request for the changes you made into closeTag.

@deemeetar

Do you mean i should submit this file first to CodeMirror2 original project?

@deemeetar deemeetar closed this
@deemeetar deemeetar reopened this
@RaymondLim
Collaborator

Yes, you need to submit the new file to CodeMirror project first and keep this pull request with the change you made to closetag.js so that I can merge with your other pull request for auto closing tag.

@deemeetar deemeetar referenced this pull request in adobe/brackets
Merged

Close html tags #1454

@deemeetar

Ok i removed the new file from here.

@deemeetar deemeetar referenced this pull request in adobe/brackets
Closed

added autoclosing of elements like ( , [, " #1457

@RaymondLim
Collaborator

Looks good. Merging it for now.

We may need to remove this when we integrate v3 from CodeMirror since there is a different fix in the upstream.

@RaymondLim RaymondLim merged commit 1881b80 into adobe:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 27, 2012
  1. @deemeetar
  2. @deemeetar
  3. @deemeetar

    cleaning up

    deemeetar authored
Commits on Sep 14, 2012
  1. @deemeetar

    removed new file

    deemeetar authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/util/closetag.js
View
2  lib/util/closetag.js
@@ -41,7 +41,7 @@
var mode = cm.getOption('mode');
- if (mode == 'text/html' || mode == 'xml') {
+ if (mode == 'text/html' || mode == 'xml' || mode == 'htmlmixed') {
/*
* Relevant structure of token:
Something went wrong with that request. Please try again.