Fix to use closeTag in brackets and addon for closeElement #76

Merged
merged 4 commits into from Oct 2, 2012

2 participants

@spiroski

This fix in the addon is needed so i could implement closeTag in brackets

The second commit is addon for autoclosing Parentheses, Brackets, and Braces

@RaymondLim

@deemeetar You're adding a new file into CodeMirror. So would you please submit your new file into upstream first since you're the original author of the new file?

And leave this pull request for the changes you made into closeTag.

@spiroski

Do you mean i should submit this file first to CodeMirror2 original project?

@spiroski spiroski closed this Sep 6, 2012
@spiroski spiroski reopened this Sep 6, 2012
@RaymondLim

Yes, you need to submit the new file to CodeMirror project first and keep this pull request with the change you made to closetag.js so that I can merge with your other pull request for auto closing tag.

@spiroski spiroski referenced this pull request in adobe/brackets Sep 13, 2012
Merged

Close html tags #1454

@spiroski

Ok i removed the new file from here.

@spiroski spiroski referenced this pull request in adobe/brackets Oct 2, 2012
Closed

added autoclosing of elements like ( , [, " #1457

@RaymondLim

Looks good. Merging it for now.

We may need to remove this when we integrate v3 from CodeMirror since there is a different fix in the upstream.

@RaymondLim RaymondLim merged commit 1881b80 into adobe:master Oct 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment