Feature/typedMapTo #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generic argument with gives you a typed EditConfig.
…typed-mapTo * commit 'f85e2fac453151a345c6040d43cdb61aadbd0fce': (29 commits) chore(release): 1.0.7 [skip ci] fix(docs): remove --mode from docs build after a typedoc breaking change chore(deps): update dependency @adobe/aem-spa-page-model-manager to ~1.3.0 style(releaserc): adapt code style to eslint warnings chore(release): 1.0.6 [skip ci] fix: docs generation command typo, releasing from dist directory chore(release): 1.0.5 [skip ci] fix: proper pkgRoot for semantic-release chore(release): 1.0.4 [skip ci] ci(tslint): add tslint config Revert "ci(actions): use eslint action" ci(actions): use eslint action fix(package.json): cleanup fix(eslint): adapt code according to eslint reports refactor(eslint): adjust code chore: cleanup refactor: cleanup chore(deps): update dependency @adobe/aem-spa-page-model-manager to ~1.2.0 ci(npm): update token chore: update docs location and `.gitignore` ... # Conflicts: # src/lib/layout/aem-component.directive.spec.ts # src/lib/layout/component-mapping.spec.ts # src/lib/layout/component-mapping.ts # src/lib/test/mapping.ts # src/lib/test/test-comp1.component.ts # src/lib/test/test-comp2.component.ts # src/lib/test/test-comp3.component.ts
…apTo * feature/lazyloadable-components-2: Linting fixes # Conflicts: # src/lib/layout/aem-component.directive.ts # src/lib/layout/component-mapping.spec.ts # src/lib/layout/component-mapping.ts # src/lib/test/test-comp1.component.ts # src/lib/test/test-comp2.component.ts # src/lib/test/test-comp3.component.ts
MapTo and LazyMapTo are now typed with a generic extending MappedComponentProperties. Use the interface MappedComponentProperties, abstract class AbstractMappedComponent or the any type to fix your build. BREAKING CHANGE: 🧨 Generic Typed MapTo / LazyMapTo
Now you can lazy load your code splitted components on demand using a Promise.
…lazyloadable-components-2 * commit '0e6a09772169325637f07ea704f630ca371402e9': chore(deps): update dependency @adobe/aem-spa-component-mapping to ~1.1.0
…lazyloadable-components-2 * commit '623be741d2243a86c06491081e9fc09a0d9dc7a5': Update CHANGELOG.md
…) unfortunately.
Instead use this approach:
LazyMapTo('lazycomponent4')(() => import('../test/lazy-component-wrapper/lazy.component').then((m) => m.LazyComponent));
…apTo * feature/lazyloadable-components-2: Add unit test coverage for lazyloading directive Add / correct some comments Remove default approach, this does not work with AOT compilation (ivy) unfortunately. `formatting formatting formatting formatting formatting formatting Adding default support for the lazyloading so imports can be simplified chore(deps): update dependency @adobe/aem-spa-component-mapping to ~1.1.0 Update CHANGELOG.md feat: 🎸 LazyMapTo support # Conflicts: # src/lib/layout/aem-component.directive.spec.ts # src/lib/layout/aem-component.directive.ts # src/lib/layout/component-mapping.spec.ts # src/lib/layout/component-mapping.ts
…mponents & ease of use
…typed-mapTo * commit '36f71d715a11ac7013ce2a37f42425801939d5c6': chore(release): 1.1.0 [skip ci] feat: support lazy loading chore: enable security check for external contribs chore: fix github action to not run twice # Conflicts: # CHANGELOG.md # src/lib/layout/aem-component.directive.spec.ts # src/lib/layout/aem-component.directive.ts # src/lib/layout/component-mapping.spec.ts # src/lib/layout/component-mapping.ts # src/lib/test/lazy-component-wrapper/lazy.component.ts # src/lib/test/test-comp1.component.ts # src/lib/test/test-comp2.component.ts # src/lib/test/test-comp3.component.ts
formatting
added 6 commits
January 12, 2021 06:15
This was referenced Jun 14, 2021
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Providing typed mapTo functionality
Related Issue
#47
Motivation and Context
Be able to use typesafety in MapTo and not be restricted to any, but with backwards compatibility.
How Has This Been Tested?
Unit test + local builds
Screenshots (if appropriate):
Types of changes
Checklist: