Skip to content

Conversation

@cjelger
Copy link
Contributor

@cjelger cjelger commented Dec 12, 2019

  • added i18n option to all hard-coded user-facing strings

- added i18n option to all hard-coded user-facing strings
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #162 into master will increase coverage by 14.81%.
The diff coverage is 88.93%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #162       +/-   ##
=============================================
+ Coverage     42.54%   57.36%   +14.81%     
- Complexity        0      462      +462     
=============================================
  Files            96      145       +49     
  Lines          2597     3990     +1393     
  Branches        537      688      +151     
=============================================
+ Hits           1105     2289     +1184     
- Misses         1492     1612      +120     
- Partials          0       89       +89
Flag Coverage Δ Complexity Δ
#jest 37.89% <77.77%> (+1.62%) 0 <0> (ø) ⬇️
#karma 93.54% <92.3%> (-0.12%) 0 <0> (ø)
#unittests 82.24% <88.99%> (?) 462 <70> (?)
Impacted Files Coverage Δ Complexity Δ
...ls/v1/storeviewexporter/StoreViewExporterImpl.java 100% <ø> (ø) 4 <0> (?)
...al/models/v1/categorylist/CategoriesRetriever.java 100% <ø> (ø) 4 <0> (?)
...onents/models/productcarousel/ProductCarousel.java 0% <0%> (ø) 0 <0> (?)
react-components/src/utils/hooks.js 94.44% <100%> (ø) 0 <0> (ø) ⬇️
...e/core/components/client/MagentoGraphqlClient.java 93.1% <100%> (ø) 9 <0> (?)
...models/v1/productcarousel/ProductCarouselImpl.java 71.73% <50%> (ø) 12 <4> (?)
...nal/models/v1/productteaser/ProductTeaserImpl.java 58% <66.66%> (ø) 16 <2> (?)
...components/src/components/Checkout/editableForm.js 43.24% <71.42%> (+40.38%) 0 <0> (ø) ⬇️
...dels/v1/categorylist/FeaturedCategoryListImpl.java 80% <83.33%> (ø) 5 <2> (?)
...models/v1/relatedproducts/RelatedProductsImpl.java 87.5% <87.5%> (ø) 13 <13> (?)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7631986...3aa6fe7. Read the comment docs.

Copy link
Contributor

@mhaack mhaack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the footer component has many demo texts we might want to clean up later. But that is not related to the PR ;-)

@herzog31 herzog31 merged commit 374fe40 into master Jan 7, 2020
@herzog31 herzog31 deleted the CIF-1148 branch January 7, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants