Skip to content

Conversation

@mhaack
Copy link
Contributor

@mhaack mhaack commented Mar 11, 2020

Description

Move CIF Connector dependency from CIF Core Components to reference project. Corresponding PR for CIF Archetype: adobe/aem-cif-project-archetype#90

Related Issue

CIF-1306

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #222   +/-   ##
=========================================
  Coverage     60.09%   60.09%           
  Complexity      539      539           
=========================================
  Files           147      147           
  Lines          4368     4368           
  Branches        745      745           
=========================================
  Hits           2625     2625           
  Misses         1652     1652           
  Partials         91       91
Flag Coverage Δ Complexity Δ
#jest 38.21% <ø> (ø) 0 <ø> (ø) ⬇️
#karma 94.97% <ø> (ø) 0 <ø> (ø) ⬇️
#unittests 84.88% <ø> (ø) 539 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac85b84...4ebf2d9. Read the comment docs.

@LSantha LSantha merged commit de52353 into master Mar 12, 2020
@LSantha LSantha deleted the issues/CIF-1306 branch March 12, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants