diff --git a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/Label.java b/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/Label.java index f1358b939c..a7106b9f97 100644 --- a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/Label.java +++ b/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/Label.java @@ -21,10 +21,21 @@ /** * Interface for a label * - * @since com.adobe.cq.forms.core.components.models.form 5.4.0 + * @since com.adobe.cq.forms.core.components.models.form 0.0.1 */ @ConsumerType -public interface Label extends TextContent { +public interface Label { + + /** + * Returns {@code true} if label is rich text, otherwise {@code false}. + * + * @return {@code true} if label is rich text, otherwise {@code false} + * @since com.adobe.cq.forms.core.components.models.form 0.0.1 + */ + @Nullable + default Boolean isRichText() { + return null; + } /** * Returns {@code true} if label should be visible, otherwise {@code false}. @@ -37,4 +48,15 @@ default Boolean isVisible() { return null; } + /** + * Returns the value of this label. + * + * @return the value of this label + * @since com.adobe.cq.forms.core.components.models.form 0.0.1 + */ + @Nullable + default String getValue() { + return null; + } + } diff --git a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/OptionsConstraint.java b/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/OptionsConstraint.java index da35adad08..2b949352d7 100644 --- a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/OptionsConstraint.java +++ b/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/OptionsConstraint.java @@ -17,7 +17,6 @@ import org.osgi.annotation.versioning.ProviderType; -import com.fasterxml.jackson.annotation.JsonIgnore; import com.fasterxml.jackson.annotation.JsonProperty; /** @@ -58,17 +57,5 @@ default boolean isEnforceEnum() { * @return the list of enum names * @since com.adobe.cq.forms.core.components.models.form 0.0.1 */ - @Deprecated - @JsonIgnore String[] getEnumNames(); - - /** - * Returns a list of RichText to be displayed to the end user. - * The length of enum and enumNames array must match - * - * @return the list of enum names - * @since com.adobe.cq.forms.core.components.models.form 5.4.0 - */ - @JsonProperty("enumNames") - TextContent[] getEnumNamesAsTextContent(); } diff --git a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/TextContent.java b/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/TextContent.java deleted file mode 100644 index 248c78b9eb..0000000000 --- a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/TextContent.java +++ /dev/null @@ -1,51 +0,0 @@ -/*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - ~ Copyright 2023 Adobe - ~ - ~ Licensed under the Apache License, Version 2.0 (the "License"); - ~ you may not use this file except in compliance with the License. - ~ You may obtain a copy of the License at - ~ - ~ http://www.apache.org/licenses/LICENSE-2.0 - ~ - ~ Unless required by applicable law or agreed to in writing, software - ~ distributed under the License is distributed on an "AS IS" BASIS, - ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - ~ See the License for the specific language governing permissions and - ~ limitations under the License. - ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/ -package com.adobe.cq.forms.core.components.models.form; - -import org.jetbrains.annotations.Nullable; -import org.osgi.annotation.versioning.ProviderType; - -/** - * Interface to represent text as rich content - * - * @since com.adobe.cq.forms.core.components.models.form 5.4.0 - */ -@ProviderType -public interface TextContent { - - /** - * Returns {@code true} if text is rich, otherwise {@code false}. - * - * @return {@code true} if text is rich, otherwise {@code false} - * @since com.adobe.cq.forms.core.components.models.form 5.4.0 - */ - @Nullable - default Boolean isRichText() { - return null; - } - - /** - * Returns a user friendly text to display for the possible options to be shown to the end user. - * - * @return the content of this text - * @since com.adobe.cq.forms.core.components.models.form 5.4.0 - */ - @Nullable - default String getValue() { - return null; - } - -} diff --git a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/package-info.java b/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/package-info.java index e68a93b679..1ed91396cf 100644 --- a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/package-info.java +++ b/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/package-info.java @@ -34,7 +34,7 @@ * version, is bound to this proxy component resource type. *
*/ -@Version("5.4.0") // aligning this with release/650 since af2-rest-api is compiled with 5.2.0 in release/650 +@Version("5.3.0") // aligning this with release/650 since af2-rest-api is compiled with 5.2.0 in release/650 package com.adobe.cq.forms.core.components.models.form; import org.osgi.annotation.versioning.Version; diff --git a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/util/AbstractOptionsFieldImpl.java b/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/util/AbstractOptionsFieldImpl.java index 10dabbbd46..90fe5ba473 100644 --- a/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/util/AbstractOptionsFieldImpl.java +++ b/bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/util/AbstractOptionsFieldImpl.java @@ -29,9 +29,6 @@ import com.adobe.cq.forms.core.components.models.form.Field; import com.adobe.cq.forms.core.components.models.form.OptionsConstraint; -import com.adobe.cq.forms.core.components.models.form.TextContent; -import com.fasterxml.jackson.annotation.JsonIgnore; -import com.fasterxml.jackson.annotation.JsonInclude; /** * Abstract class which can be used as base class for options {@link Field} implementations. @@ -52,10 +49,6 @@ public abstract class AbstractOptionsFieldImpl extends AbstractFieldImpl impleme @Nullable protected String[] enumNames; - @ValueMapValue(injectionStrategy = InjectionStrategy.OPTIONAL, name = "areOptionsRichText") - @Nullable - private Boolean areOptionsRichText; - @Override public boolean isEnforceEnum() { return enforceEnum; @@ -102,8 +95,6 @@ public Object[] getEnums() { } @Override - @Deprecated - @JsonIgnore public String[] getEnumNames() { if (enumNames != null) { Map