Skip to content

Dev to master 8th july 2024 #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 8, 2024
Merged

Dev to master 8th july 2024 #1302

merged 5 commits into from
Jul 8, 2024

Conversation

@deepprakash345
Copy link
Contributor

@deepprakash345 deepprakash345 commented Jul 8, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

rajatofficial and others added 5 commits June 28, 2024 11:40
@rajatofficial @rajatkhurana-adobe
FORMS-14275 Embed config override tests apply (#1294)
1da1a32 
* FORMS-14275 test cases applied

* FORMS-14275 test cases wait removed

* FORMS-14275 test cases fixed

---------

Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
@nit23uec
fix(eds): json encoding breaks form in eds (#1296)
45c3d65
@rismehta
Using org level sona credentials
d92ce31
@rismehta
Improving date picker test case as per customer use-case (#1299)
efb336c 
* Improving date picker test case as per customer use-case

* Update datepicker.runtime.spec.js
@rismehta
FORMS-14687 Fixing initialization of tabsontop runtime (#1298)
c226e52 
* Tab issue

* FORMS-14687 Fixing initialization of tabsontop runtime
@review @sakarora
DOD(Yes)

* FORMS-14687 Fixing initialization of tabsontop runtime
    @review @sakarora
    DOD(Yes)

* Update tabsontop.runtime.spec.js
@deepprakash345 deepprakash345 requested a review from nit23uec July 8, 2024 06:35
@codecov
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.58%. Comparing base (debfe3b) to head (c226e52).
Report is 581 commits behind head on master.

Files Patch % Lines
...ponents/internal/form/FormStructureParserImpl.java 81.25% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1302      +/-   ##
============================================
+ Coverage     81.52%   81.58%   +0.05%     
  Complexity      847      847              
============================================
  Files            96       96              
  Lines          2252     2259       +7     
  Branches        307      306       -1     
============================================
+ Hits           1836     1843       +7     
- Misses          256      257       +1     
+ Partials        160      159       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adobe-bot
Copy link

adobe-bot commented Jul 8, 2024

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

adobe-bot commented Jul 8, 2024

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 100 75

@adobe-bot
Copy link

adobe-bot commented Jul 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

2 similar comments
@adobe-bot
Copy link

adobe-bot commented Jul 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@adobe-bot
Copy link

adobe-bot commented Jul 8, 2024

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

@rismehta rismehta merged commit 7f88214 into master Jul 8, 2024
@rismehta rismehta deleted the dev_to_master_8thJuly_2024 branch July 8, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nit23uec nit23uec nit23uec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deepprakash345 @adobe-bot @nit23uec @rismehta @rajatofficial