Skip to content

Approval checkbox required by default #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Approval checkbox required by default #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63ca937
Approval checkbox required by default
Jul 18, 2024
5e070ea
FORMS-15481 Adding ui change event to update model value (#1327)
rismehta Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ps/forms-components-examples/components/form/termsandconditions/_cq_template/.content.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
jcr:title="I agree to the terms & conditions"
sling:resourceType="core/fd/components/form/checkbox/v1/checkbox"
enabled="false"
required="true"
Copy link
Contributor

@barshat7 barshat7 Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the changes in archetype proxy also
https://github.com/adobe/aem-project-archetype/blob/develop/src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/adaptiveForm/termsandconditions/_cq_template.xml

checkedValue="true"
fieldType="checkbox">
</approvalcheckbox>
Expand Down
1 change: 1 addition & 0 deletions ...ot/apps/core/fd/components/form/termsandconditions/v1/termsandconditions/_cq_template.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
jcr:primaryType="nt:unstructured"
jcr:title="I agree to the terms &amp; conditions"
sling:resourceType="core/fd/components/form/checkbox/v1/checkbox"
required="true"
enabled="false"
checkedValue="true"
fieldType="checkbox">
Expand Down
22 changes: 21 additions & 1 deletion ui.tests/test-module/specs/termsandconditions/tnc.runtime.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,5 +110,25 @@ describe("Form Runtime with Terms and Conditions", () => {
})
})
});
})

it('checkbox should be required by default', () => {
const tncWithLinksID = formContainer._model.items[1].id;
const model = formContainer._model.getElement(tncWithLinksID)
expect(model.getState().items[0].enabled).to.equal(false);
cy.get(`#${tncWithLinksID}`).get('a').click()
.then(() => {
expect(model.getState().items[0].enabled).to.equal(true);
cy.get(`#${tncWithLinksID} .cmp-adaptiveform-checkbox`).invoke('attr', 'data-cmp-enabled')
.should('eq', 'true');
cy.get(`#${tncWithLinksID} .cmp-adaptiveform-checkbox`).click()
.then(() => {
cy.get(`#${tncWithLinksID} .cmp-adaptiveform-checkbox__errormessage`).should('be.empty');
})
cy.get(`#${tncWithLinksID} .cmp-adaptiveform-checkbox`).dblclick().should('not.be.checked')
.then(() => {
cy.get(`#${tncWithLinksID} .cmp-adaptiveform-checkbox__errormessage`).should('not.be.null');
})
})
})

})