-
Notifications
You must be signed in to change notification settings - Fork 64
FORMS-16296 Adding fragment test and fixing rules issue inside fragment #1390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b154439
FORMS-16296 Adding fragment test and fixing rules issue inside fragment
rismehta 6fd7038
FORMS-16296 Adding fragment test and fixing rules issue inside fr…
rismehta 7991cbf
FORMS-16296 Adding fragment test and fixing rules issue inside fragment
rismehta 7dd8f2d
Fixing package lock json
rismehta 1a2629c
Adding test cases for fragment referred twice in the same form
rismehta ff47ce7
Fixing test skip
rismehta 062ef2e
Fixing test
rismehta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 32 additions & 19 deletions
51
.../content/jcr_root/content/forms/af/core-components-it/samples/fragment/basic/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,48 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" | ||
| jcr:primaryType="cq:Page"> | ||
| jcr:primaryType="cq:Page"> | ||
| <jcr:content | ||
| cq:deviceGroups="[mobile/groups/responsive]" | ||
| cq:lastModified="{Date}2023-01-09T16:01:24.451+05:30" | ||
| cq:lastModifiedBy="admin" | ||
| cq:template="/conf/core-components-examples/settings/wcm/templates/af-blank-v2" | ||
| jcr:language="en" | ||
| jcr:primaryType="cq:PageContent" | ||
| jcr:title="Adaptive Form V2 (IT)" | ||
| sling:resourceType="forms-components-examples/components/page"> | ||
| cq:deviceGroups="[mobile/groups/responsive]" | ||
| cq:lastModified="{Date}2024-09-10T14:57:01.796+05:30" | ||
| cq:lastModifiedBy="admin" | ||
| cq:template="/conf/core-components-examples/settings/wcm/templates/af-blank-v2" | ||
| jcr:language="en" | ||
| jcr:primaryType="cq:PageContent" | ||
| jcr:title="Adaptive Form V2 (IT)" | ||
| sling:resourceType="forms-components-examples/components/page"> | ||
| <guideContainer | ||
| fd:version="2.1" | ||
| jcr:primaryType="nt:unstructured" | ||
| sling:resourceType="forms-components-examples/components/form/container" | ||
| dorType="none" | ||
| themeRef="/libs/fd/af/themes/canvas" | ||
| fieldType="form"> | ||
| fd:version="2.1" | ||
| jcr:primaryType="nt:unstructured" | ||
| sling:resourceType="forms-components-examples/components/form/container" | ||
| dorType="none" | ||
| fieldType="form" | ||
| themeRef="/libs/fd/af/themes/canvas"> | ||
| <fragment | ||
| jcr:lastModified="{Date}2023-06-02T12:34:24.990+05:30" | ||
| jcr:lastModifiedBy="admin" | ||
| jcr:primaryType="nt:unstructured" | ||
| jcr:title="Fragment" | ||
| sling:resourceType="forms-components-examples/components/form/fragment" | ||
| fieldType="panel" | ||
| fragmentPath="/content/forms/af/core-components-it/samples/fragment/test-fragment" | ||
| maxOccur="4" | ||
| minOccur="0" | ||
| name="fragment1685689465369" | ||
| repeatable="{Boolean}true" | ||
| wrapData="{Boolean}true"/> | ||
| <fragment1 | ||
| jcr:lastModified="{Date}2023-06-02T12:34:24.990+05:30" | ||
| jcr:lastModifiedBy="admin" | ||
| jcr:primaryType="nt:unstructured" | ||
| jcr:title="Fragment" | ||
| jcr:title="Fragment 1" | ||
| sling:resourceType="forms-components-examples/components/form/fragment" | ||
| fieldType="panel" | ||
| fragmentPath="/content/forms/af/core-components-it/samples/fragment/test-fragment" | ||
| repeatable="{Boolean}true" | ||
| maxOccur="4" | ||
| minOccur="0" | ||
| name="fragment1685689465369" | ||
| name="fragment16856894653691" | ||
| repeatable="{Boolean}true" | ||
| wrapData="{Boolean}true"/> | ||
| </guideContainer> | ||
| </jcr:content> | ||
| </jcr:root> | ||
| </jcr:root> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also add a test case where the same fragment is added multiple times (need to check if core components provide new id to the fields)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Added the same