Skip to content

Conversation

@anshikag-adobe
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

let todayDate = new Date();
cy.get(".dp-caption").invoke("text").should("eq", "مارس, 2024");
cy.get(".dp-caption").click();
cy.get(".dp-caption").eq(3).click();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing existing test, means that this is backward incompatible change. What was the reason for adding this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @rismehta! Previously, whenever we used to add date-time picker widget to the form, the calendar element associated to widget is initialised and created only once even if there are multiple instances of the widget, i.e., same calendar element being initialised to every unique instance of date-time picker widget which was conflicting when interacting with each of it.

Now since there are multiple calendar elements, in the tests I had to specify which element the click() event had to occur on, hence the changes.

@codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (a0b4060) to head (02789fc).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1432   +/-   ##
=========================================
  Coverage     82.24%   82.24%           
  Complexity      923      923           
=========================================
  Files           103      103           
  Lines          2366     2366           
  Branches        321      321           
=========================================
  Hits           1946     1946           
  Misses          257      257           
  Partials        163      163           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta rismehta merged commit f90346f into dev Oct 4, 2024
@rismehta rismehta deleted the issue/FORMS-16264 branch October 4, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants