Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breadcrumb] Missing aria-label="Breadcrumb" on nav element #581

Closed
jakublamprecht opened this issue May 10, 2019 · 2 comments
Closed

[Breadcrumb] Missing aria-label="Breadcrumb" on nav element #581

jakublamprecht opened this issue May 10, 2019 · 2 comments
Labels
enhancement New feature, or improvement to an existing feature.
Milestone
2.6.0

Comments

@jakublamprecht
Copy link
Contributor

Bug Report

Current Behavior
Breadcrumb component misses aria-label attribute with value Breadcrumb on <nav> tag as specified by W3C in the following links:

https://www.w3.org/TR/wai-aria-practices/examples/breadcrumb/index.html
https://www.w3.org/TR/wai-aria-practices/#breadcrumb

Expected behavior/code
Aria label is present on the <nav> tag.

Environment

  • Core Components version 2.3.0

Possible Solution

<nav class="cmp-breadcrumb"
     data-sly-use.breadcrumb="com.adobe.cq.wcm.core.components.models.Breadcrumb"
     data-sly-use.template="core/wcm/components/commons/v1/templates.html"
     data-sly-test="${breadcrumb.items.size > 0}"
     aria-label="breadcrumb">
@richardhand richardhand added enhancement New feature, or improvement to an existing feature. good first issue Good starter issue for new contributors. labels May 10, 2019
@richardhand
Copy link
Contributor

richardhand commented May 10, 2019 •
edited

Thanks @jakublamprecht for the suggestion! If you like, feel free to go ahead and make a pull request with this change.

It is also recommends to highlight current, which we could also do for the list item representing the current page.

@gabrielwalt gabrielwalt added this to the 2.6.0 milestone Jul 2, 2019
@richardhand richardhand mentioned this issue Jul 17, 2019
Closed
@jakublamprecht jakublamprecht mentioned this issue Jul 22, 2019
Merged
richardhand pushed a commit that referenced this issue Jul 22, 2019
@jakublamprecht @richardhand
[Breadcrumb] Missing aria-label="Breadcrumb" on nav element (#671)
c034802 
- added aria-label

fixes #581
@richardhand richardhand added done and removed good first issue Good starter issue for new contributors. labels Jul 22, 2019
@richardhand richardhand modified the milestones: 2.5.2, 2.6.0 Aug 27, 2019
@richardhand
Copy link
Contributor

Code is merged to master and will be available in the upcoming 2.6.0 Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, or improvement to an existing feature.
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
3 participants
@gabrielwalt @jakublamprecht @richardhand