New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack build breaks aio-lib-ims in runtime actions #55
Comments
|
cc @shazron |
|
JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-892 |
|
Is there an ETA on when this will be released? |
|
@davidjgonzalez , we are currently prioritizing the issues and enhancement requests that are open. |
|
Update: After an offline conversation with @meryllblanchet (thank you for explaining!) -- So, no ETA required for me anymore :) It is against Adobe Firefly (which is my use-case) best practices to have the runtime action obtain the Adobe IO Access Token. Instead, I need to have the service that INVOKES my Firefly app (Runtime action) to obtain/keep-fresh the Adobe IO access token, and PASS it to my Firefly app, for use within my action! You can read on this pattern at: https://github.com/AdobeDocs/project-firefly/blob/master/guides/security_overview.md |
|
Thanks for the great summary and discussion @davidjgonzalez ! On our side we are evaluating options to fix this issue and will provide an update soon. |
|
We should be able to address this issue by having a different webpack builds (one for CLI and one for deployed action). |
@davidjgonzalez our use case where we need the action to generate the access token is triggered by whisk/alarms package. as far as I know I can't pass any access token to the action - means I need some solution to generate the access token on tuntime. |
|
@UrsBoller thanks for the feedback about your use-case! In both SPA and headless scenarios, the application should not bake the token for its own usage, as documented in the guidelines above. We'll follow-up to give you the most appropriate recommendation in order to enable your use-case. |
|
@meryllblanchet the problem is that my headless action get's triggered only by whisk/alarms. I just need a way to access adobe products (especially adobe analytics) somehow - I just try to figure out a way to get a valid token ... happy to hear any possible solution apart from using auo-lib-ims... |
|
@UrsBoller we will sync-up with @duynguyen to review the app solution design and provide the appropriate recommendations. About this issue itself: we are wrapping up the preliminary Runtime / App plugins refactoring this week (to follow here: adobe/aio-cli-plugin-runtime#191). We will then be able to work towards a resolution. |
|
Added PR to fix this - #56 |
|
Same issue here. (And yes I know it should not be used that way, but I have a temporary special case.) Workaround: use patch-package with this patch file in Thanks @moritzraho's hint in the OP. |
|
We expect to release the fix within the next two weeks - see #56. |
moritzraho commentedAug 11, 2020
•
edited
Relates to #33
Description
When invoking an action that use the lateset aio-lib-ims and was deployed via
aio app deloy(built with webpack) we get the following error:The same error appears if we unzip
dist/myaction.zipand import theindex.jsin a node REPLReproduce
aio app init-> select only actionsnpm install @adobe/aio-lib-imsWorkaround (partial)
use aio-lib-ims 4.0.1 to access the
Imsobject,getTokenwon't work because of #33What causes the error
In 4.0.1...4.1.0diff-d8c50dc3673a2b383c6c1a0a0c19799fR17-R19, removing the import to
const imsCliPlugin = require('@adobe/aio-lib-ims-oauth/src/ims-cli')andconst imsOAuthPlugin = require('@adobe/aio-lib-ims-oauth')fixes the problemThe text was updated successfully, but these errors were encountered: