From 150e300d32ecfd5ce0d0250d797ccceb10e72762 Mon Sep 17 00:00:00 2001 From: Jason San Jose Date: Wed, 3 Oct 2012 11:12:49 -0700 Subject: [PATCH] add TODO for issue #1759 --- appshell/appshell_extensions_mac.mm | 2 +- appshell/appshell_extensions_win.cpp | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/appshell/appshell_extensions_mac.mm b/appshell/appshell_extensions_mac.mm index f86d91aa0..a7da50c0b 100644 --- a/appshell/appshell_extensions_mac.mm +++ b/appshell/appshell_extensions_mac.mm @@ -344,7 +344,7 @@ int32 MakeDir(ExtensionString path, int32 mode) NSError* error = nil; NSString* pathStr = [NSString stringWithUTF8String:path.c_str()]; - // TODO: honor mode + // TODO (issue #1759): honor mode [[NSFileManager defaultManager] createDirectoryAtPath:pathStr withIntermediateDirectories:FALSE attributes:nil error:&error]; return ConvertNSErrorCode(error, false); diff --git a/appshell/appshell_extensions_win.cpp b/appshell/appshell_extensions_win.cpp index 185c3d5b7..142456b85 100644 --- a/appshell/appshell_extensions_win.cpp +++ b/appshell/appshell_extensions_win.cpp @@ -556,6 +556,7 @@ int32 ReadDir(ExtensionString path, CefRefPtr& directoryContents) int32 MakeDir(ExtensionString path, int32 mode) { + // TODO (issue #1759): honor mode if (!CreateDirectory(path.c_str(), NULL)) return ConvertWinErrorCode(GetLastError(), false);