Skip to content

Launch Chrome with the full path to the executable instead of 'start chrome' #243

Merged
merged 2 commits into from May 13, 2013

3 participants

@gruehle
Adobe Systems Incorporated member
gruehle commented May 13, 2013

A couple people have reported a "security error" when starting live development (adobe/brackets#3795). This should resolve that problem.

@bchintx
bchintx commented May 13, 2013

This change fixes the "Windows Security" - "These files can't be opened" error that I was receiving. I am now able to use Live Preview and Show Developer Tools on my Win7 machine. Yay!

Also, the shell code change looks great.

@redmunds redmunds was assigned May 13, 2013
@redmunds redmunds commented on the diff May 13, 2013
appshell/appshell_extensions_win.cpp
@@ -353,7 +353,7 @@ int32 OpenLiveBrowser(ExtensionString argURL, bool enableRemoteDebugging)
PROCESS_INFORMATION pi = {0};
// Launch cmd.exe and pass in the arguments
- if (!CreateProcess(_wgetenv(L"COMSPEC"), argsBuf.get(), NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi)) {
+ if (!CreateProcess(NULL, argsBuf.get(), NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi)) {
@redmunds
redmunds added a note May 13, 2013

Weren't these lines also added for starting from the command line?

    si.dwFlags = STARTF_USESHOWWINDOW;
    si.wShowWindow = SW_HIDE;

If so, do you still want them?

@gruehle
Adobe Systems Incorporated member
gruehle added a note May 13, 2013

Ah, yes. Good catch. Those lines don't seem to be doing any harm, but they are not needed any more. Removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@redmunds

Done with review.

@gruehle
Adobe Systems Incorporated member
gruehle commented May 13, 2013

Changes pushed. Ready for re-review.

@redmunds

Merging.

@redmunds redmunds merged commit 2e39c27 into master May 13, 2013
@redmunds redmunds deleted the glenn/chrome-launch branch May 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.