Fix potential crash when reloading Brackets #249

Merged
merged 1 commit into from May 23, 2013

Projects

None yet

2 participants

@gruehle
Adobe Systems Incorporated member

When reloading Brackets, there is a short period of time where the old V8 context is still around, but has been detached from the browser. Any calls to our V8 extensions during that time will fail. Previously, this would crash. With this change, we simply ignore the request and return false to signal that we didn't handle the request.

@gruehle gruehle referenced this pull request in adobe/brackets May 23, 2013
Closed

Tern freezes Brackets for certain JS libraries #3977

@redmunds redmunds was assigned May 23, 2013
@redmunds

Looks good. Merging.

@redmunds redmunds merged commit f791fb9 into master May 23, 2013
@redmunds redmunds deleted the glenn/crash-on-refresh branch May 23, 2013
@gruehle gruehle referenced this pull request in adobe/brackets Jul 20, 2013
Closed

WSOD when reloading Brackets with dev tools open #4522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment