Fix Open Dialog Title #255

Merged
merged 3 commits into from Jun 7, 2013

2 participants

@JeffryBooher

Passing a title to brackets.fs.showOpenFileDialog is ignored and not displayed in the file open dialog title:

adobe/brackets#1574

@redmunds redmunds was assigned Jun 5, 2013
@redmunds

This fixes the File > Open... case, but the File > Open Folder... case looks like it needs the same fix. According to the CHOOSE_FOLDER string in strings.js, the title should be "Choose a folder", but I see "Select Folder".

@redmunds

Done with initial review.

@JeffryBooher

@redmunds good catch. I saw that we were passing it to SHBrowseForFolder but didn't realize that we do something different for vista which was not setting the dialog title. This is now fixed.

@redmunds

Looks good. Merging.

@redmunds redmunds merged commit dd86a06 into master Jun 7, 2013
@redmunds redmunds deleted the jeff/fix_fileopen_title branch Jun 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment