Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix Live Development issues with Chrome OSX (round 2) #382

Merged
merged 2 commits into from Nov 18, 2013

Conversation

Projects
None yet
2 participants
Contributor

fungl164 commented Nov 15, 2013

This provides better real-time detection/separation of Chrome debug sessions, as well as better connectivity + window/tab management from within Brackets.

Reverts => #381
Fixes => adobe/brackets#5989
Requires => adobe/brackets#6003

@fungl164 fungl164 Fix Live Development issues with Chrome OSX
This reverts commit 2f543d2, reversing
changes made to c8e714d.
Also fixes issue with invalid SBApplication object causing Brackets to
hang on close.
fdffae9

@redmunds redmunds was assigned Nov 15, 2013

Contributor

fungl164 commented Nov 18, 2013

Revised + simplified pulls #371, #373 and #379

Contributor

fungl164 commented Nov 18, 2013

@redmunds Based on what we now know...this should be a simpler, cleaner approach that hits all known past issues at the right place. Let me know how your testing goes.

Contributor

redmunds commented Nov 18, 2013

Thanks. I'll be looking at this today.

Contributor

redmunds commented Nov 18, 2013

@fungl164 Thanks for sticking with this one! Looks good. Merging.

@redmunds redmunds added a commit that referenced this pull request Nov 18, 2013

@redmunds redmunds Merge pull request #382 from fungl164/osx-live
Fix Live Development issues with Chrome OSX (round 2)
59006d5

@redmunds redmunds merged commit 59006d5 into adobe:master Nov 18, 2013

Contributor

fungl164 commented Nov 19, 2013

@redmunds Just doing what I set out to do.

Thanks for supporting my crazy idea (to go off the beaten path) and staying the course. Obviously, this wouldn't be possible without everyone's participation. Now let's hope this one really sticks and delivers on its promise. :)

@redmunds redmunds added a commit that referenced this pull request Dec 8, 2015

@redmunds redmunds Merge pull request #382 from fungl164/osx-live
Fix Live Development issues with Chrome OSX (round 2)
95359d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment