Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update all path buffers to accept long UNC paths #397

Merged
merged 2 commits into from Dec 6, 2013

Conversation

Projects
None yet
4 participants
Contributor

JeffryBooher commented Dec 6, 2013

@ghost ghost assigned redmunds Dec 6, 2013

Contributor

bchintx commented Dec 6, 2013

@redmunds I noticed that there were merge conflicts w/ my other pull request. So, I took the liberty of updating this branch as well, so that it can be Merged.

Contributor

redmunds commented Dec 6, 2013

Thanks.

Contributor

redmunds commented Dec 6, 2013

@JeffryBooher This change increases the buffer size from 260 to 4096 which allows brackets-shell to handle longer file paths.

But the bug report states: "... the buffer should be large enough to accommodate collections of paths. In my particular installation, I needed to support several thousand file selections to deal with image sequences."

Does this add support for collections of paths that support "several thousand file selections" as requested in the bug?

Member

njx commented Dec 6, 2013

I wonder what the use case for selecting a thousand files in the Open dialog is...seems a bit outside our wheelhouse.

Contributor

redmunds commented Dec 6, 2013

@njx I'd like to get feedback from original filer about a usage scenario, but I think this should probably be merged to get the longer file paths. Agreed?

Member

njx commented Dec 6, 2013

Yup, I definitely think this makes sense to merge--was just thinking that we don't really need to generalize it for the "thousands of paths" case yet until we understand why that's valuable.

Contributor

redmunds commented Dec 6, 2013

Looks good. Merging.

redmunds added a commit that referenced this pull request Dec 6, 2013

Merge pull request #397 from adobe/jeff/fix-5270
Update all path buffers to accept long UNC paths

@redmunds redmunds merged commit 08ff9ab into master Dec 6, 2013

@redmunds redmunds deleted the jeff/fix-5270 branch Dec 6, 2013

Contributor

JeffryBooher commented Dec 6, 2013

@redmunds @njx this change works
For collections because the File
Open dialog uses a null terminated strings in the buffer to delineate each entry and a double null to terminate the string. The first entry is the path followed by each individual file name selected so it doesn't blow out the buffer size requirements to handle multiple file selections. Hipefully this is big enough to handle most cases.

redmunds added a commit that referenced this pull request Dec 8, 2015

Merge pull request #397 from adobe/jeff/fix-5270
Update all path buffers to accept long UNC paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment