Permalink
Browse files

Um, let's try this again. Don't show parens in About dialog if we don…

…'t have a SHA.
  • Loading branch information...
1 parent 8e32100 commit 1131695844d8b5ef7c94007d02057078d9593613 @njx njx committed Dec 12, 2012
Showing with 4 additions and 2 deletions.
  1. +4 −2 src/help/HelpCommandHandlers.js
@@ -59,7 +59,7 @@ define(function (require, exports, module) {
var templateVars = $.extend({
ABOUT_ICON : brackets.config.about_icon,
APP_NAME_ABOUT_BOX : brackets.config.app_name_about,
- BUILD_INFO : buildInfo
+ BUILD_INFO : buildInfo || ""
}, Strings);
Dialogs.showModalDialogUsingTemplate(Mustache.render(AboutDialogTemplate, templateVars));
}
@@ -77,7 +77,9 @@ define(function (require, exports, module) {
BuildInfoUtils.getBracketsSHA().done(function (branch, sha, isRepo) {
// If we've successfully determined a "build number" via .git metadata, add it to dialog
sha = sha ? sha.substr(0, 9) : "";
- buildInfo = StringUtils.format("({0} {1})", branch, sha).trim();
+ if (branch || sha) {
+ buildInfo = StringUtils.format("({0} {1})", branch, sha).trim();
+ }
});
CommandManager.register(Strings.CMD_SHOW_EXTENSIONS_FOLDER, Commands.HELP_SHOW_EXT_FOLDER, _handleShowExtensionsFolder);

0 comments on commit 1131695

Please sign in to comment.