From 312a8f4e29864aced5c5e459cb2cf9559874fe1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Malbr=C3=A1n?= Date: Fri, 22 Mar 2013 02:01:24 -0300 Subject: [PATCH] Fixes after first review --- src/editor/Editor.js | 6 +++--- src/editor/EditorStatusBar.js | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/editor/Editor.js b/src/editor/Editor.js index 63aa80ad989..a5dd692f4a5 100644 --- a/src/editor/Editor.js +++ b/src/editor/Editor.js @@ -1334,7 +1334,7 @@ define(function (require, exports, module) { */ function _setEditorOptionAndPref(value, cmOption, prefName) { _setEditorOption(value, cmOption); - _prefs.setValue(prefName, (typeof value === "boolean") ? Boolean(value) : value); + _prefs.setValue(prefName, value); } /** @@ -1351,7 +1351,7 @@ define(function (require, exports, module) { Editor.getUseTabChar = function () { return _useTabChar; }; - + /** * Sets tab character width. Affects all Editors. * @param {number} value @@ -1366,7 +1366,7 @@ define(function (require, exports, module) { Editor.getTabSize = function () { return _tabSize; }; - + /** * Sets indentation width. Affects all Editors. * @param {number} value diff --git a/src/editor/EditorStatusBar.js b/src/editor/EditorStatusBar.js index 66356080dc4..d3c56c41bbb 100644 --- a/src/editor/EditorStatusBar.js +++ b/src/editor/EditorStatusBar.js @@ -103,10 +103,11 @@ define(function (require, exports, module) { return; } + value = Math.max(Math.min(value, 10), 1); if (Editor.getUseTabChar()) { - Editor.setTabSize(Math.max(Math.min(value, 10), 1)); + Editor.setTabSize(value); } else { - Editor.setSpaceUnits(Math.max(Math.min(value, 10), 1)); + Editor.setSpaceUnits(value); } // update indicator