From 6b647c8add1b1fba7cdd60d3dd5f95321f489501 Mon Sep 17 00:00:00 2001 From: eliezerb Date: Thu, 13 Nov 2014 02:20:39 -0200 Subject: [PATCH 1/2] Adding input types to focusable elements #9476 --- src/brackets.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/brackets.js b/src/brackets.js index e0d5e728334..d9c30d054d8 100644 --- a/src/brackets.js +++ b/src/brackets.js @@ -409,9 +409,15 @@ define(function (require, exports, module) { // Text fields should always be focusable. var $target = $(e.target), isFormElement = - $target.is("input[type=text]") || + $target.is("input[type=date]") || + $target.is("input[type=email]") || $target.is("input[type=number]") || $target.is("input[type=password]") || + $target.is("input[type=search]") || + $target.is("input[type=tel]") || + $target.is("input[type=text]") || + $target.is("input[type=time]") || + $target.is("input[type=url]") || $target.is("input:not([type])") || // input with no type attribute defaults to text $target.is("textarea") || $target.is("select"); From a7a0870febe10ae3f110bb2eec066f7c1493b55a Mon Sep 17 00:00:00 2001 From: eliezerb Date: Thu, 13 Nov 2014 09:29:04 -0200 Subject: [PATCH 2/2] Replacing specific input types for a general solution --- src/brackets.js | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/brackets.js b/src/brackets.js index d9c30d054d8..d5593fb708f 100644 --- a/src/brackets.js +++ b/src/brackets.js @@ -409,16 +409,7 @@ define(function (require, exports, module) { // Text fields should always be focusable. var $target = $(e.target), isFormElement = - $target.is("input[type=date]") || - $target.is("input[type=email]") || - $target.is("input[type=number]") || - $target.is("input[type=password]") || - $target.is("input[type=search]") || - $target.is("input[type=tel]") || - $target.is("input[type=text]") || - $target.is("input[type=time]") || - $target.is("input[type=url]") || - $target.is("input:not([type])") || // input with no type attribute defaults to text + $target.is("input") || $target.is("textarea") || $target.is("select");