From a8f5dfb8bf484bb288a95c61b17bb26a1d7b5ef8 Mon Sep 17 00:00:00 2001
From: Peter Flynn <pflynn@adobe.com>
Date: Fri, 23 Mar 2012 16:51:49 -0700
Subject: [PATCH 01/12] Experimental feature: return CSS selector search
 results from HTML <style> blocks too

---
 src/editor/InlineEditorProviders.js |   2 +-
 src/language/CSSUtils.js            | 112 +++++++++++++++++++++++-----
 2 files changed, 94 insertions(+), 20 deletions(-)

diff --git a/src/editor/InlineEditorProviders.js b/src/editor/InlineEditorProviders.js
index 8bbba6b873f..83b32a2410e 100644
--- a/src/editor/InlineEditorProviders.js
+++ b/src/editor/InlineEditorProviders.js
@@ -221,7 +221,7 @@ define(function (require, exports, module) {
 
         var result = new $.Deferred();
 
-        CSSUtils.findMatchingRules(selectorName)
+        CSSUtils.findMatchingRules(selectorName, editor.document)
             .done(function (rules) {
                 if (rules && rules.length > 0) {
                     var rule = rules[0];  // For Sprint 4 we use the first match only
diff --git a/src/language/CSSUtils.js b/src/language/CSSUtils.js
index 87c22c88a08..38d94eda77c 100644
--- a/src/language/CSSUtils.js
+++ b/src/language/CSSUtils.js
@@ -183,8 +183,8 @@ define(function (require, exports, module) {
      *
      * @param text {!String} CSS text to search
      * @param selector {!String} selector to search for
-     * @return {Array.<{line:number, declListEndLine:number}>} Array of objects containing the start
-     *      and end line numbers (0-based, inclusive range) for each matched selector.
+     * @return {Array.<{selectorGroupStartLine:number, declListEndLine:number}>} Array of objects
+     *      containing the start and end line numbers (0-based, inclusive range) for each matched selector.
      */
     function _findAllMatchingSelectorsInText(text, selector) {
         var allSelectors = extractAllSelectors(text);
@@ -238,29 +238,46 @@ define(function (require, exports, module) {
      *  .foo.bar {}
      *
      * @param {!String} selector The selector to match. This can be a tag selector, class selector or id selector
+     * @param {!Document} htmlDocument An HTML file for context (so we can search <style> blocks)
      * @return {$.Promise} that will be resolved with an Array of objects containing the
      *      source document, start line, and end line (0-based, inclusive range) for each matching declaration list.
      *      Does not addRef() the documents returned in the array.
      */
-    function findMatchingRules(selector) {
+    function findMatchingRules(selector, htmlDocument) {
         var result          = new $.Deferred(),
             cssFilesResult  = FileIndexManager.getFileInfoList("css"),
-            selectors       = [];
+            resultSelectors = [];
+        
+        // Asynchronously search for matches in all the project's CSS files
+        findMatchingRulesInCSSFiles(selector, resultSelectors)
+            .done(function () {
+                // Synchronously search for matches in <style> blocks
+                findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors);
+                
+                result.resolve(resultSelectors);
+            })
+            .fail(function (error) {
+                result.reject(error);
+            });
+        
+        return result.promise();
+    }
+    
+    /** Finds matching selectors in CSS files; appends them to 'resultSelectors' */
+    function findMatchingRulesInCSSFiles(selector, resultSelectors) {
+        var result          = new $.Deferred(),
+            cssFilesResult  = FileIndexManager.getFileInfoList("css");
         
         function _loadFileAndScan(fullPath, selector) {
             var result = new $.Deferred();
             
             DocumentManager.getDocumentForPath(fullPath)
                 .done(function (doc) {
-                    var localResults = _findAllMatchingSelectorsInText(doc.getText(), selector);
+                    // Find all matching rules for the given CSS file's content, and add them to the
+                    // overall search result
+                    var oneCSSFileResults = _findAllMatchingSelectorsInText(doc.getText(), selector);
+                    addSelectorResults(resultSelectors, oneCSSFileResults, doc, 0);
                     
-                    localResults.forEach(function (value) {
-                        selectors.push({
-                            document: doc,
-                            lineStart: value.selectorGroupStartLine,
-                            lineEnd: value.declListEndLine
-                        });
-                    });
                     result.resolve();
                 })
                 .fail(function (error) {
@@ -274,18 +291,75 @@ define(function (require, exports, module) {
             Async.doInParallel(fileInfos, function (fileInfo, number) {
                 return _loadFileAndScan(fileInfo.fullPath, selector);
             })
-                .done(function () {
-                    result.resolve(selectors);
-                })
-                .fail(function (error) {
-                    console.log("Error reading CSS files.");
-                    result.reject(error);
-                });
+                .pipe(result.resolve, result.reject);
         });
         
         return result.promise();
     }
     
+    /** Finds matching selectors in the <style> block of an HTML file; appends them to 'resultSelectors' */
+    function findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors) {
+        // Find all <style> blocks in the HTML file
+        var styleBlocks = findStyleBlocksInHTML(htmlDocument.getText());
+        
+        styleBlocks.forEach(function (styleBlockInfo) {
+            // Find all matching rules for the given <style> block's content, and add them to the
+            // overall search result
+            var oneStyleBlockResults = _findAllMatchingSelectorsInText(styleBlockInfo.text, selector);
+            addSelectorResults(resultSelectors, oneStyleBlockResults, htmlDocument, styleBlockInfo.startLine);
+        });
+    }
+    
+    /**
+     * Converts the results of _findAllMatchingSelectorsInText() into a simpler bag of data and
+     * appends those new objects to the given 'resultSelectors' Array.
+     */
+    function addSelectorResults(resultSelectors, selectorsToAdd, sourceDoc, lineOffset) {
+        selectorsToAdd.forEach(function (selector) {
+            resultSelectors.push({
+                document: sourceDoc,
+                lineStart: selector.selectorGroupStartLine + lineOffset,
+                lineEnd: selector.declListEndLine + lineOffset
+            });
+        });
+    }
+    
+    /** Returns an Array of entries for all the <style> blocks in the given string of HTML */
+    function findStyleBlocksInHTML(htmlText) {
+        // FIXME: finding by regexp is fragile; this will break if any <style> tags are present
+        // inside comments, attribute value strings, or CDATA blocks
+        
+        // Note: [\s\S] is a way of saying "any char"; we can't use . because in JavaScript . never
+        // matches newlines
+        var styleBlockFinder = /<style>([\s\S]*?)<\/style>/g;
+        
+        var styleBlocks = [];
+        var styleBlockFindResult = styleBlockFinder.exec(htmlText);
+        while (styleBlockFindResult) {
+            var startIndex = styleBlockFindResult.index;
+            styleBlocks.push({
+                startLine: indexToLineNumber(htmlText, startIndex),
+                text: styleBlockFindResult[1]
+            });
+            styleBlockFindResult = styleBlockFinder.exec(htmlText);
+        }
+        return styleBlocks;
+    }
+    
+    /** Given an index into a string, returns that position's 0-based line number */
+    function indexToLineNumber(text, index) {
+        var newlineFinder = /\r?\n/g;
+        var newlines = 0;
+        
+        var newlineFindResult = newlineFinder.exec(text);
+        while (newlineFindResult && newlineFindResult.index <= index) {
+            newlines++;
+            newlineFindResult = newlineFinder.exec(text);
+        }
+        return newlines;
+    }
+    
+    
     exports._findAllMatchingSelectorsInText = _findAllMatchingSelectorsInText; // For testing only
     exports.findMatchingRules = findMatchingRules;
     exports.extractAllSelectors = extractAllSelectors;

From bed48a11105abe17e5a6397addc545c360fa5ef5 Mon Sep 17 00:00:00 2001
From: Peter Flynn <pflynn@adobe.com>
Date: Fri, 23 Mar 2012 17:17:11 -0700
Subject: [PATCH 02/12] Fix unit tests: allow leaving the HTML document out of
 the CSS search, since unit tests don't have one available.

---
 src/language/CSSUtils.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/language/CSSUtils.js b/src/language/CSSUtils.js
index 38d94eda77c..8b688d07bea 100644
--- a/src/language/CSSUtils.js
+++ b/src/language/CSSUtils.js
@@ -238,7 +238,7 @@ define(function (require, exports, module) {
      *  .foo.bar {}
      *
      * @param {!String} selector The selector to match. This can be a tag selector, class selector or id selector
-     * @param {!Document} htmlDocument An HTML file for context (so we can search <style> blocks)
+     * @param {?Document} htmlDocument An HTML file for context (so we can search <style> blocks)
      * @return {$.Promise} that will be resolved with an Array of objects containing the
      *      source document, start line, and end line (0-based, inclusive range) for each matching declaration list.
      *      Does not addRef() the documents returned in the array.
@@ -252,7 +252,9 @@ define(function (require, exports, module) {
         findMatchingRulesInCSSFiles(selector, resultSelectors)
             .done(function () {
                 // Synchronously search for matches in <style> blocks
-                findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors);
+                if (htmlDocument) {
+                    findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors);
+                }
                 
                 result.resolve(resultSelectors);
             })

From 2d0cc9f6e89d4f0162fce51649e3ba19ad65d50a Mon Sep 17 00:00:00 2001
From: Peter Flynn <pflynn@adobe.com>
Date: Mon, 26 Mar 2012 17:34:06 -0700
Subject: [PATCH 03/12] Refine <style>-block-finder to use CodeMirror tokenizer
 for robustness (e.g. it now properly ignores comments). Move to HTMLUtils.

Also:
- Fix bug in HTMLUtils._moveNextToken() where it didn't signal the last
token in the file correctly.
- Fix bug in HTMLUtils.getTagInfo() that accidentally added stuff to the
global jQuery object and then passed it around as internal state(!)
---
 src/language/CSSUtils.js  | 40 +++--------------------------------
 src/language/HTMLUtils.js | 44 +++++++++++++++++++++++++++++++++++++--
 2 files changed, 45 insertions(+), 39 deletions(-)

diff --git a/src/language/CSSUtils.js b/src/language/CSSUtils.js
index 8b688d07bea..a17c4d44e03 100644
--- a/src/language/CSSUtils.js
+++ b/src/language/CSSUtils.js
@@ -13,6 +13,7 @@ define(function (require, exports, module) {
     
     var Async               = require("utils/Async"),
         DocumentManager     = require("document/DocumentManager"),
+        HTMLUtils           = require("language/HTMLUtils"),
         FileIndexManager    = require("project/FileIndexManager"),
         NativeFileSystem    = require("file/NativeFileSystem").NativeFileSystem;
 
@@ -302,13 +303,13 @@ define(function (require, exports, module) {
     /** Finds matching selectors in the <style> block of an HTML file; appends them to 'resultSelectors' */
     function findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors) {
         // Find all <style> blocks in the HTML file
-        var styleBlocks = findStyleBlocksInHTML(htmlDocument.getText());
+        var styleBlocks = HTMLUtils.findStyleBlocks(htmlDocument._masterEditor);
         
         styleBlocks.forEach(function (styleBlockInfo) {
             // Find all matching rules for the given <style> block's content, and add them to the
             // overall search result
             var oneStyleBlockResults = _findAllMatchingSelectorsInText(styleBlockInfo.text, selector);
-            addSelectorResults(resultSelectors, oneStyleBlockResults, htmlDocument, styleBlockInfo.startLine);
+            addSelectorResults(resultSelectors, oneStyleBlockResults, htmlDocument, styleBlockInfo.start.line);
         });
     }
     
@@ -326,41 +327,6 @@ define(function (require, exports, module) {
         });
     }
     
-    /** Returns an Array of entries for all the <style> blocks in the given string of HTML */
-    function findStyleBlocksInHTML(htmlText) {
-        // FIXME: finding by regexp is fragile; this will break if any <style> tags are present
-        // inside comments, attribute value strings, or CDATA blocks
-        
-        // Note: [\s\S] is a way of saying "any char"; we can't use . because in JavaScript . never
-        // matches newlines
-        var styleBlockFinder = /<style>([\s\S]*?)<\/style>/g;
-        
-        var styleBlocks = [];
-        var styleBlockFindResult = styleBlockFinder.exec(htmlText);
-        while (styleBlockFindResult) {
-            var startIndex = styleBlockFindResult.index;
-            styleBlocks.push({
-                startLine: indexToLineNumber(htmlText, startIndex),
-                text: styleBlockFindResult[1]
-            });
-            styleBlockFindResult = styleBlockFinder.exec(htmlText);
-        }
-        return styleBlocks;
-    }
-    
-    /** Given an index into a string, returns that position's 0-based line number */
-    function indexToLineNumber(text, index) {
-        var newlineFinder = /\r?\n/g;
-        var newlines = 0;
-        
-        var newlineFindResult = newlineFinder.exec(text);
-        while (newlineFindResult && newlineFindResult.index <= index) {
-            newlines++;
-            newlineFindResult = newlineFinder.exec(text);
-        }
-        return newlines;
-    }
-    
     
     exports._findAllMatchingSelectorsInText = _findAllMatchingSelectorsInText; // For testing only
     exports.findMatchingRules = findMatchingRules;
diff --git a/src/language/HTMLUtils.js b/src/language/HTMLUtils.js
index 8aea88269d8..5b1b5dce4f0 100644
--- a/src/language/HTMLUtils.js
+++ b/src/language/HTMLUtils.js
@@ -44,7 +44,7 @@ define(function (require, exports, module) {
         var eol = ctx.editor.getLine(ctx.pos.line).length;
         if (ctx.pos.ch >= eol || ctx.token.end >= eol) {
             //move down a line
-            if (ctx.pos.line === ctx.editor.lineCount()) {
+            if (ctx.pos.line >= ctx.editor.lineCount() - 1) {
                 return false; //at the bottom
             }
             ctx.pos.line++;
@@ -261,7 +261,7 @@ define(function (require, exports, module) {
         //we're going to changing pos a lot, but we don't want to mess up
         //the pos the caller passed in so we use extend to make a safe copy of it.	
         //This is what pass by value in c++ would do.	
-        var pos = $.extend(constPos),
+        var pos = $.extend({}, constPos),
             ctx = _getInitialContext(editor._codeMirror, pos),
             offset = _offsetInToken(ctx),
             tagInfo,
@@ -335,6 +335,45 @@ define(function (require, exports, module) {
         return tagInfo;
     }
     
+    
+    /**
+     * Returns an Array of info about all <style> blocks in the given Editor's HTML document (assumes
+     * the Editor contains HTML text).
+     */
+    function findStyleBlocks(editor) {
+        var ctx = _getInitialContext(editor._codeMirror, {line:0, ch:0});
+        var offset = _offsetInToken(ctx);
+        
+        var styleBlocks = [];
+        var currentStyleBlock = null;
+        var inStyleBlock = false;
+        
+        while ( _moveNextToken(ctx) ) {
+            if (inStyleBlock) {
+                // Check for end of this <style> block
+                if (ctx.token.state.mode !== "css") {
+                    currentStyleBlock.text = editor._codeMirror.getRange(currentStyleBlock.start, currentStyleBlock.end);
+                    inStyleBlock = false;
+                } else {
+                    currentStyleBlock.end = { line: ctx.pos.line, ch: ctx.pos.ch };
+                }
+            } else {
+                // Check for start of a <style> block
+                if (ctx.token.state.mode === "css") {
+                    currentStyleBlock = {
+                        start: { line: ctx.pos.line, ch: ctx.pos.ch }
+                    };
+                    styleBlocks.push(currentStyleBlock);
+                    inStyleBlock = true;
+                }
+                // else, random token in non-CSS content: ignore
+            }
+        }
+        
+        return styleBlocks;
+    }
+    
+    
     // Define public API
     exports.TAG_NAME = TAG_NAME;
     exports.ATTR_NAME = ATTR_NAME;
@@ -344,4 +383,5 @@ define(function (require, exports, module) {
     //The createTagInfo is really only for the unit tests so they can make the same structure to 
     //compare results with
     exports.createTagInfo = createTagInfo;
+    exports.findStyleBlocks = findStyleBlocks;
 });

From 18a4b66f824b83a901d4317c12f6f22d0b3d3d00 Mon Sep 17 00:00:00 2001
From: Peter Flynn <pflynn@adobe.com>
Date: Mon, 26 Mar 2012 17:59:21 -0700
Subject: [PATCH 04/12] Clean up HTML <style>-block-finding code; fix JSLint
 complaints

---
 src/language/CSSUtils.js  | 129 ++++++++++++++++++++------------------
 src/language/HTMLUtils.js |   7 ++-
 2 files changed, 72 insertions(+), 64 deletions(-)

diff --git a/src/language/CSSUtils.js b/src/language/CSSUtils.js
index a17c4d44e03..a9e253114c4 100644
--- a/src/language/CSSUtils.js
+++ b/src/language/CSSUtils.js
@@ -222,74 +222,51 @@ define(function (require, exports, module) {
         return result;
     }
     
+    
     /**
-     * Return all rules matching the specified selector.
-     * For Sprint 4, we only look at the rightmost simple selector. For example, searching for ".foo" will 
-     * match these rules:
-     *  .foo {}
-     *  div .foo {}
-     *  div.foo {}
-     *  div .foo[bar="42"] {}
-     *  div .foo:hovered {}
-     *  div .foo::first-child
-     * but will *not* match these rules:
-     *  .foobar {}
-     *  .foo .bar {}
-     *  div .foo .bar {}
-     *  .foo.bar {}
-     *
-     * @param {!String} selector The selector to match. This can be a tag selector, class selector or id selector
-     * @param {?Document} htmlDocument An HTML file for context (so we can search <style> blocks)
-     * @return {$.Promise} that will be resolved with an Array of objects containing the
-     *      source document, start line, and end line (0-based, inclusive range) for each matching declaration list.
-     *      Does not addRef() the documents returned in the array.
+     * Converts the results of _findAllMatchingSelectorsInText() into a simpler bag of data and
+     * appends those new objects to the given 'resultSelectors' Array.
+     * @param {Array.<{document:Document, lineStart:number, lineEnd:number}>} resultSelectors
+     * @param {Array.<{selectorGroupStartLine:number, declListEndLine:number}>} selectorsToAdd
+     * @param {!Document} sourceDoc
+     * @param {!number} lineOffset Amount to offset all line number info by. Used if the first line
+     *          of the parsed CSS text is not the first line of the sourceDoc.
      */
-    function findMatchingRules(selector, htmlDocument) {
-        var result          = new $.Deferred(),
-            cssFilesResult  = FileIndexManager.getFileInfoList("css"),
-            resultSelectors = [];
-        
-        // Asynchronously search for matches in all the project's CSS files
-        findMatchingRulesInCSSFiles(selector, resultSelectors)
-            .done(function () {
-                // Synchronously search for matches in <style> blocks
-                if (htmlDocument) {
-                    findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors);
-                }
-                
-                result.resolve(resultSelectors);
-            })
-            .fail(function (error) {
-                result.reject(error);
+    function addSelectorsToResults(resultSelectors, selectorsToAdd, sourceDoc, lineOffset) {
+        selectorsToAdd.forEach(function (selector) {
+            resultSelectors.push({
+                document: sourceDoc,
+                lineStart: selector.selectorGroupStartLine + lineOffset,
+                lineEnd: selector.declListEndLine + lineOffset
             });
-        
-        return result.promise();
+        });
     }
     
-    /** Finds matching selectors in CSS files; appends them to 'resultSelectors' */
+    /** Finds matching selectors in CSS files; adds them to 'resultSelectors' */
     function findMatchingRulesInCSSFiles(selector, resultSelectors) {
         var result          = new $.Deferred(),
             cssFilesResult  = FileIndexManager.getFileInfoList("css");
         
         function _loadFileAndScan(fullPath, selector) {
-            var result = new $.Deferred();
+            var oneFileResult = new $.Deferred();
             
             DocumentManager.getDocumentForPath(fullPath)
                 .done(function (doc) {
                     // Find all matching rules for the given CSS file's content, and add them to the
                     // overall search result
-                    var oneCSSFileResults = _findAllMatchingSelectorsInText(doc.getText(), selector);
-                    addSelectorResults(resultSelectors, oneCSSFileResults, doc, 0);
+                    var oneCSSFileMatches = _findAllMatchingSelectorsInText(doc.getText(), selector);
+                    addSelectorsToResults(resultSelectors, oneCSSFileMatches, doc, 0);
                     
-                    result.resolve();
+                    oneFileResult.resolve();
                 })
                 .fail(function (error) {
-                    result.reject(error);
+                    oneFileResult.reject(error);
                 });
         
-            return result.promise();
+            return oneFileResult.promise();
         }
         
+        // Load index of all CSS files; then load each CSS file in turn and search its contents
         cssFilesResult.done(function (fileInfos) {
             Async.doInParallel(fileInfos, function (fileInfo, number) {
                 return _loadFileAndScan(fileInfo.fullPath, selector);
@@ -300,35 +277,65 @@ define(function (require, exports, module) {
         return result.promise();
     }
     
-    /** Finds matching selectors in the <style> block of an HTML file; appends them to 'resultSelectors' */
+    /** Finds matching selectors in the <style> block of a single HTML file; adds them to 'resultSelectors' */
     function findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors) {
         // Find all <style> blocks in the HTML file
+        // TODO: avoid looking at _masterEditor; maybe just require htmlDoc to be current main editor?
         var styleBlocks = HTMLUtils.findStyleBlocks(htmlDocument._masterEditor);
         
         styleBlocks.forEach(function (styleBlockInfo) {
-            // Find all matching rules for the given <style> block's content, and add them to the
-            // overall search result
-            var oneStyleBlockResults = _findAllMatchingSelectorsInText(styleBlockInfo.text, selector);
-            addSelectorResults(resultSelectors, oneStyleBlockResults, htmlDocument, styleBlockInfo.start.line);
+            // Search this one <style> block's content, appending results to 'resultSelectors'
+            var oneStyleBlockMatches = _findAllMatchingSelectorsInText(styleBlockInfo.text, selector);
+            addSelectorsToResults(resultSelectors, oneStyleBlockMatches, htmlDocument, styleBlockInfo.start.line);
         });
     }
     
     /**
-     * Converts the results of _findAllMatchingSelectorsInText() into a simpler bag of data and
-     * appends those new objects to the given 'resultSelectors' Array.
+     * Return all rules matching the specified selector.
+     * For Sprint 4, we only look at the rightmost simple selector. For example, searching for ".foo" will 
+     * match these rules:
+     *  .foo {}
+     *  div .foo {}
+     *  div.foo {}
+     *  div .foo[bar="42"] {}
+     *  div .foo:hovered {}
+     *  div .foo::first-child
+     * but will *not* match these rules:
+     *  .foobar {}
+     *  .foo .bar {}
+     *  div .foo .bar {}
+     *  .foo.bar {}
+     *
+     * @param {!String} selector The selector to match. This can be a tag selector, class selector or id selector
+     * @param {?Document} htmlDocument An HTML file for context (so we can search <style> blocks)
+     * @return {$.Promise} that will be resolved with an Array of objects containing the
+     *      source document, start line, and end line (0-based, inclusive range) for each matching declaration list.
+     *      Does not addRef() the documents returned in the array.
      */
-    function addSelectorResults(resultSelectors, selectorsToAdd, sourceDoc, lineOffset) {
-        selectorsToAdd.forEach(function (selector) {
-            resultSelectors.push({
-                document: sourceDoc,
-                lineStart: selector.selectorGroupStartLine + lineOffset,
-                lineEnd: selector.declListEndLine + lineOffset
+    function findMatchingRules(selector, htmlDocument) {
+        var result          = new $.Deferred(),
+            cssFilesResult  = FileIndexManager.getFileInfoList("css"),
+            resultSelectors = [];
+        
+        // Synchronously search for matches in <style> blocks
+        if (htmlDocument) {
+            findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors);
+        }
+        
+        // Asynchronously search for matches in all the project's CSS files
+        // (results are appended together in same 'resultSelectors' array)
+        findMatchingRulesInCSSFiles(selector, resultSelectors)
+            .done(function () {
+                result.resolve(resultSelectors);
+            })
+            .fail(function (error) {
+                result.reject(error);
             });
-        });
+        
+        return result.promise();
     }
     
     
     exports._findAllMatchingSelectorsInText = _findAllMatchingSelectorsInText; // For testing only
     exports.findMatchingRules = findMatchingRules;
-    exports.extractAllSelectors = extractAllSelectors;
 });
diff --git a/src/language/HTMLUtils.js b/src/language/HTMLUtils.js
index 5b1b5dce4f0..29c92ba1e0f 100644
--- a/src/language/HTMLUtils.js
+++ b/src/language/HTMLUtils.js
@@ -339,16 +339,17 @@ define(function (require, exports, module) {
     /**
      * Returns an Array of info about all <style> blocks in the given Editor's HTML document (assumes
      * the Editor contains HTML text).
+     * @param {!Editor} editor
      */
     function findStyleBlocks(editor) {
-        var ctx = _getInitialContext(editor._codeMirror, {line:0, ch:0});
-        var offset = _offsetInToken(ctx);
+        // Start scanning from beginning of file
+        var ctx = _getInitialContext(editor._codeMirror, {line: 0, ch: 0});
         
         var styleBlocks = [];
         var currentStyleBlock = null;
         var inStyleBlock = false;
         
-        while ( _moveNextToken(ctx) ) {
+        while (_moveNextToken(ctx)) {
             if (inStyleBlock) {
                 // Check for end of this <style> block
                 if (ctx.token.state.mode !== "css") {

From b0271fa9b4432d9790ca8cac42daea410c3be228 Mon Sep 17 00:00:00 2001
From: Peter Flynn <pflynn@adobe.com>
Date: Thu, 29 Mar 2012 16:45:48 -0700
Subject: [PATCH 05/12] Cleanup: don't access Document._masterEditor

---
 src/language/CSSUtils.js | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/language/CSSUtils.js b/src/language/CSSUtils.js
index 27105c9da5d..0e2054e5cbe 100644
--- a/src/language/CSSUtils.js
+++ b/src/language/CSSUtils.js
@@ -13,6 +13,7 @@ define(function (require, exports, module) {
     
     var Async               = require("utils/Async"),
         DocumentManager     = require("document/DocumentManager"),
+        EditorManager       = require("editor/EditorManager"),
         HTMLUtils           = require("language/HTMLUtils"),
         FileIndexManager    = require("project/FileIndexManager"),
         NativeFileSystem    = require("file/NativeFileSystem").NativeFileSystem;
@@ -305,9 +306,15 @@ define(function (require, exports, module) {
     
     /** Finds matching selectors in the <style> block of a single HTML file; adds them to 'resultSelectors' */
     function findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors) {
+        // HTMLUtils requires a real CodeMirror instance; make sure we can give it the right Editor
+        var htmlEditor = EditorManager.getCurrentFullEditor();
+        if (htmlEditor.document !== htmlDocument) {
+            console.error("Cannot search for <style> blocks in HTML file other than current editor");
+            return;
+        }
+        
         // Find all <style> blocks in the HTML file
-        // TODO: avoid looking at _masterEditor; maybe just require htmlDoc to be current main editor?
-        var styleBlocks = HTMLUtils.findStyleBlocks(htmlDocument._masterEditor);
+        var styleBlocks = HTMLUtils.findStyleBlocks(htmlEditor);
         
         styleBlocks.forEach(function (styleBlockInfo) {
             // Search this one <style> block's content, appending results to 'resultSelectors'

From 343906f8712b0cebe7376181b59e81501d2e4a2a Mon Sep 17 00:00:00 2001
From: Peter Flynn <pflynn@adobe.com>
Date: Tue, 3 Apr 2012 10:38:51 -0700
Subject: [PATCH 06/12] Consistently use underscores for module-private
 functions

---
 src/language/CSSUtils.js | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/language/CSSUtils.js b/src/language/CSSUtils.js
index 0e2054e5cbe..277c0b532d4 100644
--- a/src/language/CSSUtils.js
+++ b/src/language/CSSUtils.js
@@ -40,7 +40,7 @@ define(function (require, exports, module) {
      * @param text {!String} CSS text to extract from
      * @return {Array.<Object>} Array with objects specifying selectors.
      */
-    function extractAllSelectors(text) {
+    function _extractAllSelectors(text) {
         var selectors = [];
         var mode = CodeMirror.getMode({indentUnit: 2}, "css");
         var state = CodeMirror.startState(mode);
@@ -213,7 +213,7 @@ define(function (require, exports, module) {
      *      matched selector.
      */
     function _findAllMatchingSelectorsInText(text, selector) {
-        var allSelectors = extractAllSelectors(text);
+        var allSelectors = _extractAllSelectors(text);
         var result = [];
         var i;
         
@@ -257,7 +257,7 @@ define(function (require, exports, module) {
      * @param {!number} lineOffset Amount to offset all line number info by. Used if the first line
      *          of the parsed CSS text is not the first line of the sourceDoc.
      */
-    function addSelectorsToResults(resultSelectors, selectorsToAdd, sourceDoc, lineOffset) {
+    function _addSelectorsToResults(resultSelectors, selectorsToAdd, sourceDoc, lineOffset) {
         selectorsToAdd.forEach(function (selectorInfo) {
             resultSelectors.push({
                 selector: selectorInfo.selector,
@@ -269,7 +269,7 @@ define(function (require, exports, module) {
     }
     
     /** Finds matching selectors in CSS files; adds them to 'resultSelectors' */
-    function findMatchingRulesInCSSFiles(selector, resultSelectors) {
+    function _findMatchingRulesInCSSFiles(selector, resultSelectors) {
         var result          = new $.Deferred(),
             cssFilesResult  = FileIndexManager.getFileInfoList("css");
         
@@ -282,7 +282,7 @@ define(function (require, exports, module) {
                     // Find all matching rules for the given CSS file's content, and add them to the
                     // overall search result
                     var oneCSSFileMatches = _findAllMatchingSelectorsInText(doc.getText(), selector);
-                    addSelectorsToResults(resultSelectors, oneCSSFileMatches, doc, 0);
+                    _addSelectorsToResults(resultSelectors, oneCSSFileMatches, doc, 0);
                     
                     oneFileResult.resolve();
                 })
@@ -305,7 +305,7 @@ define(function (require, exports, module) {
     }
     
     /** Finds matching selectors in the <style> block of a single HTML file; adds them to 'resultSelectors' */
-    function findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors) {
+    function _findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors) {
         // HTMLUtils requires a real CodeMirror instance; make sure we can give it the right Editor
         var htmlEditor = EditorManager.getCurrentFullEditor();
         if (htmlEditor.document !== htmlDocument) {
@@ -319,7 +319,7 @@ define(function (require, exports, module) {
         styleBlocks.forEach(function (styleBlockInfo) {
             // Search this one <style> block's content, appending results to 'resultSelectors'
             var oneStyleBlockMatches = _findAllMatchingSelectorsInText(styleBlockInfo.text, selector);
-            addSelectorsToResults(resultSelectors, oneStyleBlockMatches, htmlDocument, styleBlockInfo.start.line);
+            _addSelectorsToResults(resultSelectors, oneStyleBlockMatches, htmlDocument, styleBlockInfo.start.line);
         });
     }
     
@@ -352,12 +352,12 @@ define(function (require, exports, module) {
         
         // Synchronously search for matches in <style> blocks
         if (htmlDocument) {
-            findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors);
+            _findMatchingRulesInStyleBlocks(htmlDocument, selector, resultSelectors);
         }
         
         // Asynchronously search for matches in all the project's CSS files
         // (results are appended together in same 'resultSelectors' array)
-        findMatchingRulesInCSSFiles(selector, resultSelectors)
+        _findMatchingRulesInCSSFiles(selector, resultSelectors)
             .done(function () {
                 result.resolve(resultSelectors);
             })

From 9cb60c703785ee3f1bb70ce8fe9e7ce33a739389 Mon Sep 17 00:00:00 2001
From: Chris Bank <cbank@adobe.com>
Date: Wed, 4 Apr 2012 12:32:54 -0700
Subject: [PATCH 07/12] Remove the project reloading for now. When we do the
 file watchers story we can do a more fine grained approach for this

---
 src/brackets.js               |  1 -
 src/project/ProjectManager.js | 83 -----------------------------------
 2 files changed, 84 deletions(-)

diff --git a/src/brackets.js b/src/brackets.js
index 96048f41bce..31b7bba4061 100644
--- a/src/brackets.js
+++ b/src/brackets.js
@@ -176,7 +176,6 @@ define(function (require, exports, module) {
         function initWindowListeners() {
             // TODO: (issue 269) to support IE, need to listen to document instead (and even then it may not work when focus is in an input field?)
             $(window).focus(function () {
-                ProjectManager.reloadProject();
                 FileSyncManager.syncOpenDocuments();
                 FileIndexManager.markDirty();
             });
diff --git a/src/project/ProjectManager.js b/src/project/ProjectManager.js
index f453a162d96..f13d8a8e2e3 100644
--- a/src/project/ProjectManager.js
+++ b/src/project/ProjectManager.js
@@ -488,88 +488,6 @@ define(function (require, exports, module) {
         return result;
     }
 
-    /**
-     * Refresh the current project from disk.
-     */
-    function reloadProject() {
-        // Update prefs so tree state doesn't change.
-        // TODO (Issue #487): PreferencesManager only exposes a savePreferences() method to save
-        // preferences across all clients, but here we only want to update our own prefs.
-        PreferencesManager.savePreferences();
-
-        // reset tree node id's
-        _projectInitialLoad.id = 0;
-
-        var prefs = PreferencesManager.getPreferences(PREFERENCES_CLIENT_ID),
-            result = new $.Deferred(),
-            resultRenderTree,
-            rootPath = _projectRoot.fullPath;
-
-        _projectInitialLoad.previous = prefs.projectTreeState;
-
-        // Populate file tree as long as we aren't running in the browser
-        if (!brackets.inBrowser) {
-
-            result.done(function () {
-                _documentSelectionFocusChange();
-            });
-
-            // Point at a real folder structure on local disk
-            NativeFileSystem.requestNativeFileSystem(rootPath,
-                function (rootEntry) {
-
-                    // Success!
-                    _projectRoot = rootEntry;
-
-                    // The tree will invoke our "data provider" function to populate the top-level items, then
-                    // go idle until a node is expanded - at which time it'll call us again to fetch the node's
-                    // immediate children, and so on.
-                    resultRenderTree = _renderTree(_treeDataProvider);
-
-                    resultRenderTree.done(function () {
-                        result.resolve();
-                    });
-                    resultRenderTree.fail(function () {
-                        result.reject();
-                    });
-                },
-                function (error) {
-                    Dialogs.showModalDialog(
-                        Dialogs.DIALOG_ID_ERROR,
-                        Strings.ERROR_LOADING_PROJECT,
-                        Strings.format(
-                            Strings.REQUEST_NATIVE_FILE_SYSTEM_ERROR,
-                            rootPath,
-                            error.code,
-                            function () {
-                                result.reject();
-                            }
-                        )
-                    ).done(function () {
-                        // The current project folder no longer exists, so prompt for another one.
-                        NativeFileSystem.showOpenDialog(false, true, "Choose project folder", _projectRoot.fullPath, null,
-                            function (files) {
-                                // If length == 0, user canceled the dialog, so use default project
-                                if (files.length === 0) {
-                                    files[0] = _getDefaultProjectPath();
-                                }
-                                // Load the new project into the folder tree
-                                loadProject(files[0]);
-                            },
-                            function (error) {
-                                Dialogs.showModalDialog(
-                                    Dialogs.DIALOG_ID_ERROR,
-                                    Strings.ERROR_LOADING_PROJECT,
-                                    Strings.format(Strings.OPEN_DIALOG_ERROR, error.code)
-                                );
-                            }
-                            );
-                    });
-                }
-                );
-        }
-    }
-
     /**
      * Displays a browser dialog where the user can choose a folder to load.
      * (If the user cancels the dialog, nothing more happens).
@@ -779,7 +697,6 @@ define(function (require, exports, module) {
     exports.makeProjectRelativeIfPossible = makeProjectRelativeIfPossible;
     exports.openProject     = openProject;
     exports.loadProject     = loadProject;
-    exports.reloadProject   = reloadProject;
     exports.getSelectedItem = getSelectedItem;
     exports.createNewItem   = createNewItem;
 

From 4a45df26c11d230115c88a86b9691fba624d9538 Mon Sep 17 00:00:00 2001
From: Glenn Ruehle <gruehle@gmail.com>
Date: Wed, 4 Apr 2012 16:03:08 -0700
Subject: [PATCH 08/12] Fail silently when trying to connect to stale
 connection.

---
 src/LiveDevelopment/Inspector/Inspector.js | 10 ++++++++++
 src/LiveDevelopment/LiveDevelopment.js     |  4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/LiveDevelopment/Inspector/Inspector.js b/src/LiveDevelopment/Inspector/Inspector.js
index a465a35a6af..c06cf6904ac 100644
--- a/src/LiveDevelopment/Inspector/Inspector.js
+++ b/src/LiveDevelopment/Inspector/Inspector.js
@@ -109,6 +109,16 @@ define(function Inspector(require, exports, module) {
      * @param {object} the method signature
      */
     function _send(method, signature, varargs) {
+        if (!_socket) {
+            // FUTURE: Our current implementation closes and re-opens an inspector connection whenever
+            // a new HTML file is selected. If done quickly enough, pending requests from the previous
+            // connection could come in before the new socket connection is established. For now we 
+            // simply ignore this condition. 
+            // This race condition will go away once we support multiple inspector connections and turn
+            // off auto re-opening when a new HTML file is selected.
+            return;
+        }
+        
         console.assert(_socket, "You must connect to the WebSocket before sending messages.");
         var id, callback, args, i, params = {};
 
diff --git a/src/LiveDevelopment/LiveDevelopment.js b/src/LiveDevelopment/LiveDevelopment.js
index 132512caa43..1599b59088b 100644
--- a/src/LiveDevelopment/LiveDevelopment.js
+++ b/src/LiveDevelopment/LiveDevelopment.js
@@ -252,7 +252,7 @@ define(function LiveDevelopment(require, exports, module) {
             // For Sprint 6, we only open live development connections for HTML files
             // FUTURE: Remove this test when we support opening connections for different
             // file types.
-            if (doc.extension.indexOf('htm') !== 0) {
+            if (doc.extension && doc.extension.indexOf('htm') !== 0) {
                 return;
             }
             
@@ -342,7 +342,7 @@ define(function LiveDevelopment(require, exports, module) {
                 _openDocument(doc, editor);
             } else {
                 /* FUTURE: support live connections for docments other than html */
-                if (doc.extension.indexOf('htm') === 0) {
+                if (doc.extension && doc.extension.indexOf('htm') === 0) {
                     close();
                     setTimeout(open);
                 }

From 37896f9c5fdb38ebacc03283321d40d61803e9dd Mon Sep 17 00:00:00 2001
From: Glenn Ruehle <gruehle@gmail.com>
Date: Wed, 4 Apr 2012 17:08:07 -0700
Subject: [PATCH 09/12] Correctly handle scenario where no document is active.

---
 src/LiveDevelopment/LiveDevelopment.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/LiveDevelopment/LiveDevelopment.js b/src/LiveDevelopment/LiveDevelopment.js
index 132512caa43..22abbd86ddd 100644
--- a/src/LiveDevelopment/LiveDevelopment.js
+++ b/src/LiveDevelopment/LiveDevelopment.js
@@ -333,10 +333,12 @@ define(function LiveDevelopment(require, exports, module) {
     /** Triggered by a document change from the DocumentManager */
     function _onDocumentChange() {
         var doc = _getCurrentDocument();
+        if (!doc) {
+            return;
+        }
+        
         if (Inspector.connected()) {
-            if (!doc) {
-                close();
-            } else if (agents.network && agents.network.wasURLRequested(doc.url)) {
+            if (agents.network && agents.network.wasURLRequested(doc.url)) {
                 _closeDocument();
                 var editor = EditorManager.getCurrentFullEditor();
                 _openDocument(doc, editor);

From 74e23c06430188ed7b6ede83a85fc0875fb1a645 Mon Sep 17 00:00:00 2001
From: Glenn Ruehle <gruehle@gmail.com>
Date: Wed, 4 Apr 2012 18:40:02 -0700
Subject: [PATCH 10/12] Update CodeMirror SHA

---
 src/thirdparty/CodeMirror2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/thirdparty/CodeMirror2 b/src/thirdparty/CodeMirror2
index 2ff65afa99a..6e8e7e3d468 160000
--- a/src/thirdparty/CodeMirror2
+++ b/src/thirdparty/CodeMirror2
@@ -1 +1 @@
-Subproject commit 2ff65afa99a09296e0c03578c402da664f5a83b7
+Subproject commit 6e8e7e3d4680a9223ecfa678f38b25c2b2d2a4b8

From bedf77f696e3eb3755ed87531a43ecf6a7fab8de Mon Sep 17 00:00:00 2001
From: Narciso Jaramillo <njaramil@adobe.com>
Date: Thu, 5 Apr 2012 00:42:14 -0700
Subject: [PATCH 11/12] Make clicks in dead space in inline CSS widget set
 focus back to the actual editor and set the selection to the beginning/end

---
 src/editor/CSSInlineEditor.js | 24 +++++++++++++++++++++++-
 src/editor/Editor.js          | 33 +++++++++++++++++++++++++--------
 2 files changed, 48 insertions(+), 9 deletions(-)

diff --git a/src/editor/CSSInlineEditor.js b/src/editor/CSSInlineEditor.js
index 581308d3391..176fe414241 100644
--- a/src/editor/CSSInlineEditor.js
+++ b/src/editor/CSSInlineEditor.js
@@ -7,7 +7,7 @@
 
 define(function (require, exports, module) {
     'use strict';
-
+    
     // Load dependent modules
     var DocumentManager     = require("document/DocumentManager"),
         HTMLUtils           = require("language/HTMLUtils"),
@@ -56,6 +56,7 @@ define(function (require, exports, module) {
 
         // Bind event handlers
         this._updateRelatedContainer = this._updateRelatedContainer.bind(this);
+        this._onClick = this._onClick.bind(this);
 
         // Create DOM to hold editors and related list
         this.$editorsDiv = $(document.createElement('div')).addClass("inlineEditorHolder");
@@ -108,6 +109,9 @@ define(function (require, exports, module) {
         
         // Listen to the editor's scroll event to reposition the relatedContainer.
         $(this.hostEditor).on("scroll", this._updateRelatedContainer);
+        
+        // Listen for clicks directly on us, so we can set focus back to the editor
+        this.$htmlContent.on("click", this._onClick);
 
         return (new $.Deferred()).resolve();
     };
@@ -193,6 +197,24 @@ define(function (require, exports, module) {
         $(this.hostEditor).off("scroll", this._updateRelatedContainer);
     };
     
+    /**
+     * Handle a click outside our child editor by setting focus back to it.
+     */
+    CSSInlineEditor.prototype._onClick = function (event) {
+        var childEditor = this.editors[0],
+            editorRoot = childEditor.getRootElement(),
+            editorPos = $(editorRoot).offset();
+        if (!$.contains(editorRoot, event.target)) {
+            childEditor.focus();
+            if (event.pageY < editorPos.top) {
+                childEditor.setCursorPos(0, 0);
+            } else if (event.pageY > editorPos.top + $(editorRoot).height()) {
+                var lastLine = childEditor.getLastVisibleLine();
+                childEditor.setCursorPos(lastLine, childEditor.getLineText(lastLine).length);
+            }
+        }
+    };
+    
     /**
      *
      *
diff --git a/src/editor/Editor.js b/src/editor/Editor.js
index 46d6d4e9de3..0e5e14e7986 100644
--- a/src/editor/Editor.js
+++ b/src/editor/Editor.js
@@ -357,14 +357,8 @@ define(function (require, exports, module) {
      * bugs in CodeMirror when lines are hidden.
      */
     Editor.prototype._selectAllVisible = function () {
-        var startLine, endLine;
-        if (this._visibleRange) {
-            startLine = this._visibleRange.startLine;
-            endLine = this._visibleRange.endLine;
-        } else {
-            startLine = 0;
-            endLine = this.lineCount() - 1;
-        }
+        var startLine = this.getFirstVisibleLine(),
+            endLine = this.getLastVisibleLine();
         this.setSelection({line: startLine, ch: 0},
                           {line: endLine, ch: this.getLineText(endLine).length});
     };
@@ -664,6 +658,22 @@ define(function (require, exports, module) {
     Editor.prototype.lineCount = function () {
         return this._codeMirror.lineCount();
     };
+    
+    /**
+     * Gets the number of the first visible line in the editor.
+     * @returns {number} The 0-based index of the first visible line.
+     */
+    Editor.prototype.getFirstVisibleLine = function () {
+        return (this._visibleRange ? this._visibleRange.startLine : 0);
+    };
+    
+    /**
+     * Gets the number of the last visible line in the editor.
+     * @returns {number} The 0-based index of the last visible line.
+     */
+    Editor.prototype.getLastVisibleLine = function () {
+        return (this._visibleRange ? this._visibleRange.endLine : this.lineCount() - 1);
+    };
 
     /* Hides the specified line number in the editor
      * @param {!number}
@@ -689,6 +699,13 @@ define(function (require, exports, module) {
         return this._codeMirror.getScrollerElement();
     };
     
+    /**
+     * Gets the root DOM node of the editor.
+     * @returns {Object} The editor's root DOM node.
+     */
+    Editor.prototype.getRootElement = function () {
+        return this._codeMirror.getWrapperElement();
+    };
     
     /**
      * Adds an inline widget below the given line. If any inline widget was already open for that

From 42173b345a9e7c598dadc34576f1c69981ebd412 Mon Sep 17 00:00:00 2001
From: Glenn Ruehle <gruehle@gmail.com>
Date: Thu, 5 Apr 2012 07:20:09 -0700
Subject: [PATCH 12/12] Fix html extension check.

---
 src/LiveDevelopment/LiveDevelopment.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/LiveDevelopment/LiveDevelopment.js b/src/LiveDevelopment/LiveDevelopment.js
index 1599b59088b..869fcc18a33 100644
--- a/src/LiveDevelopment/LiveDevelopment.js
+++ b/src/LiveDevelopment/LiveDevelopment.js
@@ -252,7 +252,7 @@ define(function LiveDevelopment(require, exports, module) {
             // For Sprint 6, we only open live development connections for HTML files
             // FUTURE: Remove this test when we support opening connections for different
             // file types.
-            if (doc.extension && doc.extension.indexOf('htm') !== 0) {
+            if (!doc.extension || doc.extension.indexOf('htm') !== 0) {
                 return;
             }