error message that the script prints, and move check for missing argument before XP check to ensure that XP message doesn't print misleading paths.
listeners. And add a couple more docs.
* Revert main-editor-swapping codepath back to how it used to work, mostly disentangled from focus events. * Don't fire focusedEditorChanged on the many times focus returns to the same Editor that had it last (due to window reactivation, closing a dialog, closing a search bar, etc.). All the current use cases for this event don't care about those cases. Add more detailed docs on event cases. * Simplify how Editor signals focus: trigger only from "onFocus" (a superset of the other case), and remove _internalFocus flag that was guarding against the overlap. * Don't call resizeEditor() on every editor swap just because statusbar *might* have been shown/hidden: only call when statusbar actually did change (going to/from no editor). Fixes scrolling issue in #1864. #1257 still isn't 100% fixed: there are at least two cases where getFocusedEditor() lags behind the focusedEditorChanged event: opening an inline editor; and moving focus from open inline editor to its host editor. These same cases - and a number of others - were broken before this change, however.
…hanges to no results) Clear selection when no results found in file. Leave cursor where selection used to be, which typically was the location of an earlier matching result from before the query was done being typed. (This seems consistent with how incremental search works in other editors & browsers).
activated via menu) -- There are two problems at play. First, smart-autocomplete only listens for key events, not programmatic or other textfield changes, so we need to kick it to generate results for the prepopulated text. Second, the results are generated asynchronously while QuickOpen's auto-"focus" is synchronous. That bug is not fixed here since it's related to a whole tangle of async issues in #1855. Fixing the first bug alone means that hitting Enter now goes to the correct result (instead of doing nothing), but that the editor doesn't auto-scroll to that result as soon as the search bar is opened. This commit also cleans up QuickOpen to use KeyEvent consts for key codes.
…edundant style properties.
* Fix bug where hiding sidebar entirely didn't update .content left/width (SidebarView change). * Fix bug where no-editor placeholder didn't appear on launch if no open files were restored (EditorManager change). * Remove unused EditorManager._resizeTimeout & rename _updateEditorSize() for clarity * Add note in main-view.html about assumptions/requirements imposed on .content children's layout