New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Timing Function Quick Edit: linear is invalid syntax #10984

Closed
petetnt opened this Issue Apr 23, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@petetnt
Collaborator

petetnt commented Apr 23, 2015

Steps to reproduce:

  • Create a .css file
.test {
  animation-timing-function: linear;
}
  • Place cursor on linear and press CTRL+E, which results in CSS Timing Function Quick Edit: invalid syntax.

Expected: Timing Function Quick Edit (Bezier curve editor?) view opens up with a line representing cubic-bezier(0.0, 0.0, 1.0, 1.0) (ref MDN).

Windows 8.1, Release 1.4 development build 1.4.0-0 (master 9264e29)

@petetnt

This comment has been minimized.

Show comment
Hide comment
@petetnt

petetnt Apr 23, 2015

Collaborator

This line states that:

// The linear keyword can occur in other values, so for strict parsing we
// only detect when it's on same line as "transition"

Checking for "animation" together with transition fixes the problem.

   LINEAR_STRICT_REGEX             = /transition|animation.*?[: ,]linear[ ,;]/,

I've got a PR ready that's ok

Collaborator

petetnt commented Apr 23, 2015

This line states that:

// The linear keyword can occur in other values, so for strict parsing we
// only detect when it's on same line as "transition"

Checking for "animation" together with transition fixes the problem.

   LINEAR_STRICT_REGEX             = /transition|animation.*?[: ,]linear[ ,;]/,

I've got a PR ready that's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment