Lots of menu-related console spam #1292

Closed
peterflynn opened this Issue Jul 22, 2012 · 3 comments

Comments

Projects
None yet
3 participants
Member

peterflynn commented Jul 22, 2012

  1. Launch Brackets
  2. Open the console

Result:
Several dozen copies of this warning message: "Bad Parameter in _getRelativeMenuItem(): relativeID not specified"

Member

peterflynn commented Jul 22, 2012

This was introduced just recently, in pull #1247. Every single one of the built-in calls to addMenuItem() (to create the default Brackets menu structure) generates one of these warnigns. It looks pretty ugly, so I think we should fix it before Sprint 11 goes out the door if possible.

(It also makes it harder for extension developers to spot when their Menu API calls have done something wrong).

@peterflynn peterflynn added a commit that referenced this issue Jul 22, 2012

@peterflynn peterflynn Fix issue #1292 (Lots of menu-related console spam):
- Only warn on missing relativeID if 'position' requires a relativeID
Other minor cleanups:
- Add warning if relativeID is a section marker is but 'position' is not
  section-relative
- Remove unused $sectionItems var
- Add TODO about simpifying part of _getRelativeMenuItem()
6f04669

@joelrbrandt joelrbrandt added a commit that referenced this issue Jul 23, 2012

@joelrbrandt joelrbrandt Merge pull request #1294 from adobe/pflynn/issue-1292
Fix issue #1292 (Lots of menu-related console spam)
fb9a0da

peterflynn was assigned Jul 23, 2012

Member

joelrbrandt commented Jul 23, 2012

merged #1294. Reassigning to @peterflynn for closing

Member

pthiess commented Jul 24, 2012

Reviewed.

peterflynn closed this Jul 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment