Unit test failures in native menus #2917

Open
njx opened this Issue Feb 20, 2013 · 6 comments

Projects

None yet

3 participants

@njx
Adobe Systems Incorporated member

2 consistent failures on the build machine in native menus:

Native Menus getMenuItemState setMenuItemState should be able to set enabled state.
Native Menus getMenuItemState setMenuItemState should be able to set checked state.

@RaymondLim RaymondLim was assigned Feb 20, 2013
@njx
Adobe Systems Incorporated member

@RaymondLim - assigning to you since Glenn is going to be out, but feel free to reassign if necessary.

@gruehle
Adobe Systems Incorporated member

This seems to have fixed itself. I looked at the build machine to see if I could spot anything wrong, but didn't see anything suspicious. The next run of unit tests passed....

@RaymondLim

Have to close this as utr for now since nothing seems wrong in this specific native menu test file and it no longer reproduces on the build machine.

@RaymondLim RaymondLim closed this Feb 25, 2013
@njx njx reopened this Mar 13, 2013
@njx
Adobe Systems Incorporated member

Reopened to sprint 22 since this is happening again.

@RaymondLim

This seems to be introduced by moving Debug menu to an extension. Debug menu is loaded at a much later time from an extension and it is also inserted after the Window menu instead of before the Window menu. So the menu tests that update menu items may get interrupted by the Debug menu creation.

@gruehle gruehle was assigned Mar 26, 2013
@gruehle
Adobe Systems Incorporated member

Reviewed--marking low priority. The unit tests are disabled for now, and verifying that menus are enabled/checked has been added to the smoke tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment