Live development: Switching between iframe outer & inner pages shows unexpected content #3325

Open
peterflynn opened this Issue Apr 3, 2013 · 11 comments

Comments

Projects
None yet
4 participants
@peterflynn
Member

peterflynn commented Apr 3, 2013

Old Title: Live development: Switching between iframe outer & inner pages shows wrong content

  1. Open an HTML file with an iframe that includes another HTML file in the project
  2. Launch Live Preview
  3. In Brackets, switch to the HTML file that the iframe points at
  4. Toggle Live Preview off, then back on again
  5. Switch back to the outer HTML file

Result:
3 - page in browser does not change; console shows error "Couldn't find the tag information for (filename of inner file)"
4 - tab opens showing inner file as expected
5 - tab changes to show outer file, but the content in the iframe is a nested copy of the outer file (it actually seems to recurse twice, then stops -- so the outer file's iframe contains a copy of the outer file, whose iframe in turn includes another copy of the outer file, whose iframe in turn is blank) Fixed.

Expected:
3 - browser page switches to inner HTML file
5 - browser page switches back to outer HTML file, but it looks exactly the same as in step 2

@peterflynn

This comment has been minimized.

Show comment Hide comment
@peterflynn

peterflynn Apr 3, 2013

Member

I'm guessing this broke due to the Node static server stuff, not the new HTML highlighting... but assigning to this sprint just in case.

Member

peterflynn commented Apr 3, 2013

I'm guessing this broke due to the Node static server stuff, not the new HTML highlighting... but assigning to this sprint just in case.

@peterflynn

This comment has been minimized.

Show comment Hide comment
@peterflynn

peterflynn Apr 3, 2013

Member

Once you're in this state, it's stuck that way until you either restart the Node server or quit & relaunch the entire Brackets process. (Refreshing Brackets alone is not enough -- so something on the Node side is getting stuck in a bad state).

Member

peterflynn commented Apr 3, 2013

Once you're in this state, it's stuck that way until you either restart the Node server or quit & relaunch the entire Brackets process. (Refreshing Brackets alone is not enough -- so something on the Node side is getting stuck in a bad state).

@ghost ghost assigned redmunds Apr 8, 2013

@pthiess

This comment has been minimized.

Show comment Hide comment
@pthiess

pthiess Apr 8, 2013

Member

@peterflynn - reviewed - if this is too complicated we may punt on it in this sprint, certainly a medium priority.

Member

pthiess commented Apr 8, 2013

@peterflynn - reviewed - if this is too complicated we may punt on it in this sprint, certainly a medium priority.

@pthiess

This comment has been minimized.

Show comment Hide comment
@pthiess

pthiess Apr 8, 2013

Member

@redmunds FYI

Member

pthiess commented Apr 8, 2013

@redmunds FYI

@pthiess

This comment has been minimized.

Show comment Hide comment
@pthiess

pthiess Apr 8, 2013

Member

@peterflynn @redmunds In case this turns out as a legacy from earlier sprints - should we add this to our bug card too?

Member

pthiess commented Apr 8, 2013

@peterflynn @redmunds In case this turns out as a legacy from earlier sprints - should we add this to our bug card too?

@redmunds

This comment has been minimized.

Show comment Hide comment
@redmunds

redmunds Apr 10, 2013

Contributor

This issue reproduces in Sprint 22.

I opened a slightly different issue (#3394) that was introduced in Sprint 23.

Contributor

redmunds commented Apr 10, 2013

This issue reproduces in Sprint 22.

I opened a slightly different issue (#3394) that was introduced in Sprint 23.

@jasonsanjose

This comment has been minimized.

Show comment Hide comment
@jasonsanjose

jasonsanjose Apr 10, 2013

Member

After #3392 merged, step 3 reproduces but not step 5.

Member

jasonsanjose commented Apr 10, 2013

After #3392 merged, step 3 reproduces but not step 5.

@redmunds

This comment has been minimized.

Show comment Hide comment
@redmunds

redmunds Apr 10, 2013

Contributor

Moved to Sprint 24.

Contributor

redmunds commented Apr 10, 2013

Moved to Sprint 24.

@redmunds

This comment has been minimized.

Show comment Hide comment
@redmunds

redmunds Apr 26, 2013

Contributor

The worst part of this bug (Step 5) is fixed. The behavior in Step 3 is desirable in some workflows, so this needs more research. Moving out of Sprint 24.

Details: We continue to show top-level HTML page when included files (such as .css and .js) are selected, so they can be edited in the context of the top-level HTML page. It can also be beneficial to edit an "included" .html file in this same manner.

Currently, user can use LiveDev both ways. The workflow is to view the "included" file as a top-level HTML page is to stop and restart LiveDev. If we "fix" this problem as described in the bug report, then we block this workflow.

Even if we keep this as it is, we need to review the workflow for possible improvements. Needs research.

Contributor

redmunds commented Apr 26, 2013

The worst part of this bug (Step 5) is fixed. The behavior in Step 3 is desirable in some workflows, so this needs more research. Moving out of Sprint 24.

Details: We continue to show top-level HTML page when included files (such as .css and .js) are selected, so they can be edited in the context of the top-level HTML page. It can also be beneficial to edit an "included" .html file in this same manner.

Currently, user can use LiveDev both ways. The workflow is to view the "included" file as a top-level HTML page is to stop and restart LiveDev. If we "fix" this problem as described in the bug report, then we block this workflow.

Even if we keep this as it is, we need to review the workflow for possible improvements. Needs research.

@redmunds

This comment has been minimized.

Show comment Hide comment
@redmunds

redmunds Apr 26, 2013

Contributor

@peterflynn Your thoughts?

Contributor

redmunds commented Apr 26, 2013

@peterflynn Your thoughts?

@redmunds

This comment has been minimized.

Show comment Hide comment
@redmunds

redmunds Jun 20, 2013

Contributor

I think this behavior might be preferred, so changing to low priority.

Contributor

redmunds commented Jun 20, 2013

I think this behavior might be preferred, so changing to low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment